Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 10909184: [Chromoting] Remove Iceberg files and support. (Closed)

Created:
8 years, 3 months ago by garykac
Modified:
8 years, 3 months ago
Reviewers:
joth, Steve Block, Torne, Jamie
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org, mnaganov (inactive)
Visibility:
Public.

Description

[Chromoting] Remove Iceberg files and support. Iceberg was our old .pkg maker, but we've switched to using Packages since it supports building flat installers that can be signed (required by 10.8). Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=156334

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2288 lines) Patch
M android_webview/tools/third_party_files_whitelist.txt View 1 1 chunk +0 lines, -6 lines 0 comments Download
D remoting/host/installer/mac/ChromotingHost.packproj View 1 chunk +0 lines, -1026 lines 0 comments Download
D remoting/host/installer/mac/ChromotingHostService.packproj View 1 chunk +0 lines, -677 lines 0 comments Download
D remoting/host/installer/mac/ChromotingHostUninstaller.packproj View 1 chunk +0 lines, -551 lines 0 comments Download
M remoting/host/installer/mac/do_signing.sh View 3 chunks +6 lines, -25 lines 0 comments Download
M remoting/remoting.gyp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
garykac
8 years, 3 months ago (2012-09-12 00:30:32 UTC) #1
garykac
+joth, +steveblock, +torne (Although frankly it's a bit bizarre to require android approval to clean ...
8 years, 3 months ago (2012-09-12 00:48:27 UTC) #2
Jamie
lgtm
8 years, 3 months ago (2012-09-12 01:34:45 UTC) #3
joth
8 years, 3 months ago (2012-09-12 05:43:29 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698