Fix and re-commit -- Refactoring and tests for file_util::CreateOrUpdateShortcutLink

Fix and re-commit http://codereview.chromium.org/10914109/ (after revert in http://crrev.com/155918) -- Refactoring and tests for the highly undertested file_util::CreateOrUpdateShortcutLink() method.

Simplify file_util::CreateOrUpdateShortcutLink()'s interface (use a struct to set parameters passed which allows callers to specify exactly what they want without having to pass in a bunch of NULLs for the unused parameters).
The same concept will be used for ShellUtil's shortcut functions in an upcoming CL.

Moved ShellUtil::VerifyChromeShortcut() to file_util::VerifyShortcut() and augmented it for every shortcut properties. This will also allow other shortcut creators (web apps, profiles, etc.) to have a broader test coverage on the shortcut they create (i.e. more testable properties available).
I will leave it up to the owners of these various projects to augment their tests, this CL keeps the previously tested behavior, not more, not less.

This is the 1st CL of a massive refactoring effort for shortcuts (http://goo.gl/Az889) in which ShellUtil's shortcut methods have to be refactored (http://codereview.chromium.org/10836247/ : soon to incorporate interface changes from this CL) which led me even lower to first refactor file_util's shortcut methods.

TBR=robertshield@chromium.org, sky@chromium.org, agl@chromium.org, dgrogan@chromium.org
BUG=132825, 148539
TEST=base_unittests --gtest_filter=FileUtilShortcutTest*
installer_util_unitests --gtest_filter=ShellUtilTestWithDirAndDist*
unit_tests --gtest_filter=ProfileShortcutManagerTest*
(run tests on XP as well)

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156250

[gab, 2012-09-11 19:23:45]

@brettw: Small gyp fix to Delay load propsys.dll for exes that depend on
test_support_base as it doesn't exist on WinXP (the methods requiring it were
already in a >= base::win::VERSION_WIN7 block, but the EXEs were trying to load
the DLL at launch).

(@grt: thanks for the delay load suggestion!).

[brettw, 2012-09-11 19:26:42]

I'm a bit concerned about code in base that will crash if its called on XP. Can
we either make it fail in a nice way (preferred) or put the relevant headers in
an #ifdef?

[gab1, 2012-09-11 19:32:17]

On 2012/09/11 19:26:42, brettw wrote:
> I'm a bit concerned about code in base that will crash if its called on XP.
Can
> we either make it fail in a nice way (preferred) or put the relevant headers
in
> an #ifdef?

It will not crash if called on XP, the method "VerifyShortcut" in
base\test\test_shortcut_win.cc is Windows only, but does a few more
verifications if base::win::GetVersion() >= base::win::VERSION_WIN7.

This call can be called from any Windows version. The problem was that we depend
on propsys.lib for the Win7 only section, but the DLL was loaded when starting
the EXE (and it didn't exist on XP), with DelayLoadDLLs the DLL is only loaded
when the methods are called (which they never are on XP).

We can't #ifdef per Windows version as we compile a single binary for all
Windows versions.

[brettw, 2012-09-11 19:33:45]

Oh, I see. LGTM

[commit-bot: I haz the power, 2012-09-11 19:35:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gab@chromium.org/10909171/2001

[commit-bot: I haz the power, 2012-09-11 20:40:23]

Try job failure for 10909171-2001 (retry) on win for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[commit-bot: I haz the power, 2012-09-11 20:55:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gab@chromium.org/10909171/2001

[commit-bot: I haz the power, 2012-09-12 02:45:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gab@chromium.org/10909171/2001

[commit-bot: I haz the power, 2012-09-12 07:14:57]

Change committed as 156250