Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3732)

Unified Diff: chrome/common/logging_chrome.cc

Issue 10909164: LoggingLock::Init() should append a non-empty string to (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/logging.cc ('K') | « base/logging.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/logging_chrome.cc
===================================================================
--- chrome/common/logging_chrome.cc (revision 155649)
+++ chrome/common/logging_chrome.cc (working copy)
@@ -262,9 +262,10 @@
IPC::Logging::set_log_function_map(&g_log_function_mapping);
#endif
LoggingDestination logging_dest = DetermineLogMode(command_line);
+ LogLockingState log_locking_state = LOCK_LOG_FILE;
FilePath log_path;
#if defined(OS_CHROMEOS)
- FilePath target_path;
+ FilePath target_path;
#endif
// Don't resolve the log path unless we need to. Otherwise we leave an open
@@ -291,6 +292,8 @@
// since that will remove the newly created link instead.
delete_old_log_file = logging::APPEND_TO_OLD_LOG_FILE;
#endif
+ } else {
+ log_locking_state = DONT_LOCK_LOG_FILE;
wtc 2012/09/12 20:27:09 LogLockingState has four possible values: enum Lo
}
logging::DcheckState dcheck_state =
@@ -300,7 +303,7 @@
bool success = InitLogging(log_path.value().c_str(),
logging_dest,
- logging::LOCK_LOG_FILE,
+ log_locking_state,
delete_old_log_file,
dcheck_state);
« base/logging.cc ('K') | « base/logging.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698