Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/logging.cc

Issue 10909164: LoggingLock::Init() should append a non-empty string to (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/common/logging_chrome.cc » ('j') | chrome/common/logging_chrome.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/logging.cc
===================================================================
--- base/logging.cc (revision 155649)
+++ base/logging.cc (working copy)
@@ -297,6 +297,7 @@
// static
MutexHandle LoggingLock::log_mutex = NULL;
#elif defined(OS_POSIX)
+// TODO(wtc): this pthread_mutex_t is not process-shared!
pthread_mutex_t LoggingLock::log_mutex = PTHREAD_MUTEX_INITIALIZER;
#endif
« no previous file with comments | « no previous file | chrome/common/logging_chrome.cc » ('j') | chrome/common/logging_chrome.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698