Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 10909162: Switch use_libcc_for_compositor default to true (Closed)

Created:
8 years, 3 months ago by jamesr
Modified:
8 years, 3 months ago
Reviewers:
nduca
CC:
chromium-reviews, enne (OOO), piman, aelias_OOO_until_Jul13
Visibility:
Public.

Description

Switch use_libcc_for_compositor default to true BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=156195

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : use base::snprintf() in CCActiveAnimation.cpp to fix win build #

Patch Set 4 : #

Patch Set 5 : use base::snprintf #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M build/common.gypi View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M cc/CCActiveAnimation.cpp View 1 2 4 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jamesr
8 years, 3 months ago (2012-09-11 01:05:57 UTC) #1
jamesr
Depends on http://codereview.chromium.org/10909145/
8 years, 3 months ago (2012-09-11 01:06:14 UTC) #2
nduca
Needless to say, lgtm :)
8 years, 3 months ago (2012-09-11 03:37:06 UTC) #3
jamesr
8 years, 3 months ago (2012-09-11 03:39:15 UTC) #4
On 2012/09/11 03:37:06, nduca wrote:
> Needless to say, lgtm :)

Thanks :) Trybots say I still need:
https://chromiumcodereview.appspot.com/10917181/
https://chromiumcodereview.appspot.com/10918161/
and to use base::snprintf() in cc/CCActiveAnimation.cpp

Powered by Google App Engine
This is Rietveld 408576698