Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 10909154: Remove PPAPI dependency on 'net'. (Closed)

Created:
8 years, 3 months ago by bbudge
Modified:
8 years, 3 months ago
Reviewers:
brettw
CC:
chromium-reviews
Visibility:
Public.

Description

Remove PPAPI dependency on 'net'. This is needed to complete the port of the PPAPI proxy plugin-side to NaCl. This replaces usages in ppapi of types in 'net' with simpler base types (eg. instead of IPEndPoint, use a std::vector<unsigned char> address and an int port). Also, this removes some static methods in net_address_private_impl.* that are hardly used, and removes the ppapi::NetAddressList typedef, using std::vector<PP_NetAddress_Private> instead. BUG=116317 TEST=existing, no new functionality Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=156585

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -143 lines) Patch
M content/browser/renderer_host/pepper/pepper_message_filter.cc View 1 2 3 4 5 chunks +21 lines, -6 lines 0 comments Download
M content/browser/renderer_host/pepper/pepper_tcp_server_socket.cc View 1 2 3 4 3 chunks +12 lines, -7 lines 0 comments Download
M content/browser/renderer_host/pepper/pepper_tcp_socket.cc View 1 2 3 4 2 chunks +16 lines, -6 lines 0 comments Download
M content/browser/renderer_host/pepper/pepper_udp_socket.cc View 1 2 3 4 6 chunks +14 lines, -9 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_delegate_impl.h View 1 2 3 4 2 chunks +7 lines, -5 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_delegate_impl.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M ppapi/ppapi_internal.gyp View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/proxy/ppapi_messages.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppb_host_resolver_private_proxy.h View 1 2 3 4 1 chunk +6 lines, -5 lines 0 comments Download
M ppapi/proxy/ppb_host_resolver_private_proxy.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M ppapi/shared_impl/private/net_address_private_impl.h View 1 2 3 4 3 chunks +6 lines, -14 lines 0 comments Download
M ppapi/shared_impl/private/net_address_private_impl.cc View 1 2 3 4 9 chunks +80 lines, -51 lines 0 comments Download
M ppapi/shared_impl/private/ppb_host_resolver_shared.h View 1 2 3 4 4 chunks +5 lines, -15 lines 0 comments Download
M ppapi/shared_impl/private/ppb_host_resolver_shared.cc View 1 2 3 4 3 chunks +1 line, -20 lines 0 comments Download
M webkit/plugins/ppapi/ppb_network_monitor_private_impl.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
bbudge
Ready. Most of the action is in net_address_private_impl.cc. I adapted two methods from net::IPEndPoint, and ...
8 years, 3 months ago (2012-09-12 17:52:24 UTC) #1
bbudge
Ready. Most of the action is in net_address_private_impl.cc. I adapted two methods from net::IPEndPoint, and ...
8 years, 3 months ago (2012-09-12 17:52:34 UTC) #2
bbudge
Removed copied "sys/socket.h" defines for NaCl untrusted build. They won't be needed.
8 years, 3 months ago (2012-09-12 22:58:13 UTC) #3
brettw
8 years, 3 months ago (2012-09-13 18:00:27 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698