lib/math.cc - Issue 10909152: Fix for issue 4808 (The vm crashes when parseInt is called with string containing a $).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/math.cc

Issue 10909152: Fix for issue 4808 (The vm crashes when parseInt is called with string containing a $). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: lib/math.cc

===================================================================

--- lib/math.cc (revision 12139)

+++ lib/math.cc (working copy)

@@ -104,7 +104,8 @@

DEFINE_NATIVE_ENTRY(MathNatives_parseInt, 1) {

GET_NATIVE_ARGUMENT(String, value, arguments->At(0));

- Scanner scanner(value, String::Handle());

+ const String& dummy_key = String::Handle(Symbols::Empty());

+ Scanner scanner(value, dummy_key);

const Scanner::GrowableTokenStream& tokens = scanner.GetStream();

String* int_string;

bool is_positive;

@@ -128,7 +129,8 @@

DEFINE_NATIVE_ENTRY(MathNatives_parseDouble, 1) {