content/browser/renderer_host/pepper/content_browser_pepper_host_factory.cc - Issue 10909138: Convert the async device ID getter to a chrome resource host

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/pepper/content_browser_pepper_host_factory.cc

Issue 10909138: Convert the async device ID getter to a chrome resource host (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/pepper/browser_ppapi_host_impl.cc ('k') | content/browser/renderer_host/pepper/pepper_message_filter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/pepper/content_browser_pepper_host_factory.cc

diff --git a/content/browser/renderer_host/pepper/content_browser_pepper_host_factory.cc b/content/browser/renderer_host/pepper/content_browser_pepper_host_factory.cc

index d5e7e98a92e6939e51d73c55e9167e953b2d2e73..34ba0d3822bdad4556309d248ff6bdb101da6eed 100644

--- a/content/browser/renderer_host/pepper/content_browser_pepper_host_factory.cc

+++ b/content/browser/renderer_host/pepper/content_browser_pepper_host_factory.cc

@@ -29,11 +29,8 @@ scoped_ptr<ResourceHost> ContentBrowserPepperHostFactory::CreateResourceHost(

DCHECK(host == host_->GetPpapiHost());

// Make sure the plugin is giving us a valid instance for this resource.

- /* TODO(brettw) make this work. The browser should be aware of all valid

- instances.

if (!host_->IsValidInstance(instance))

return scoped_ptr<ResourceHost>();

- */

// Public interfaces with no permissions required.

switch (message.type()) {