Issue 10909129: Fix crash in screensaver shutdown.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10909129: Fix crash in screensaver shutdown. (Closed)

Created:
8 years, 3 months ago by rkc

Modified:
8 years, 3 months ago

Reviewers:
Daniel Erat, zel

CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, zel

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix crash in screensaver shutdown. We remove the user activity detector's observer when shutting down the kiosk mode screensaver. This apparently can cause a crash since the ash shell or the user activity detector instance's could be null by this point. Check before we do a remove. Crash report is in the bug. R=derat@chromium.org BUG=147340 TEST=None. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155526

Patch Set 1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	chrome/browser/chromeos/kiosk_mode/kiosk_mode_screensaver.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rkc@chromium.org/10909129/1

8 years, 3 months ago (2012-09-07 21:01:10 UTC) #3

Change committed as 155526

Expand Messages | Collapse Messages