Fix issue 2933 - if an exception is thrown before we start the first test, but after the testcase i…

pkg/unittest/unittest.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * A library for writing dart unit tests.
  *
  * To import this library, specify the relative path to
  * pkg/unittest/unittest.dart.
  *
@@ skipping 644 matching lines @@
   _handleCallbackFunctionComplete();
 }
 
 /**
  * Utility function that can be used to notify the test framework that an
  *  error was caught outside of this library.
  */
 void _reportTestError(String msg, String trace) {
  if (_currentTest < _tests.length) {
     final testCase = _tests[_currentTest];
-    testCase.error(msg, trace);
-    if (testCase.callbackFunctionsOutstanding > 0) {
-      _nextTestCase();
+    if (testCase.running) {

[Siggi Cherem (dart-lang), 2012/09/07 17:13:23]

seems that this means that also tests that fail after they are done running
(e.g. when an async test creates more callbacks than expected and some callbacks
happen afterwards), then we'll also mark the error as an uncaught top level
error. Is that what we want there too? or do we need to have a different state
for before/after running?

[gram, 2012/09/07 17:40:53]

I thought about that. I have mixed feelings about this. In a way, 'uncaught
error' seems like a valid way of handling this, and can possibly lead to us
simplifying the code later on, as right now we have some extra checks to deal
with the fact that an error might happen on a test that is not the currently
running test. As it is, we recently made the change where a later failure will
flip the test from pass/fail to error.

OTOH I also feel that this side effect is not really desirable in that the fix
should really address just the issue at hand. As such I have come up with an
alternative that is more specific to this issue. PTAL.

+      testCase.error(msg, trace);
+      if (testCase.callbackFunctionsOutstanding > 0) {
+        _nextTestCase();
+      }
+      return;
     }
-  } else {
-    _uncaughtErrorMessage = "$msg: $trace";
   }
+  _uncaughtErrorMessage = "$msg: $trace";
 }
 
 /** Runs [callback] at the end of the event loop. */
 _defer(void callback()) {
   // Exploit isolate ports as a platform-independent mechanism to queue a
   // message at the end of the event loop.
   // TODO(sigmund): expose this functionality somewhere in our libraries.
   final port = new ReceivePort();
   port.receive((msg, reply) {
     callback();
@@ skipping 182 matching lines @@
 }
 
 /** Enable a test by ID. */
 void enableTest(int testId) => _setTestEnabledState(testId, true);
 
 /** Disable a test by ID. */
 void disableTest(int testId) => _setTestEnabledState(testId, false);
 
 /** Signature for a test function. */
 typedef void TestFunction();