Issue 10909102: Also check for accelerated plugins when determining when 3d is really enabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10909102: Also check for accelerated plugins when determining when 3d is really enabled. (Closed)

Created:
8 years, 3 months ago by jbauman

Modified:
8 years, 3 months ago

Reviewers:
brettw

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Also check for accelerated plugins when determining when 3d is really enabled. This filters out machines where we're using SwiftShader. BUG=146876 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155338

Patch Set 1 #

Total comments: 1

Patch Set 2 : add comment #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	ppapi/shared_impl/ppapi_preferences.cc	View	1	1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

brettw

https://chromiumcodereview.appspot.com/10909102/diff/1/ppapi/shared_impl/ppapi_preferences.cc File ppapi/shared_impl/ppapi_preferences.cc (right): https://chromiumcodereview.appspot.com/10909102/diff/1/ppapi/shared_impl/ppapi_preferences.cc#newcode27 ppapi/shared_impl/ppapi_preferences.cc:27: is_webgl_supported(prefs.experimental_webgl_enabled && Actually, can you comment about why we ...

8 years, 3 months ago (2012-09-06 20:23:44 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/10909102/4001

8 years, 3 months ago (2012-09-06 20:31:14 UTC) #4

Change committed as 155338

Expand Messages | Collapse Messages