Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 10909100: Add android_gdbserver to android_webview* targets. (Closed)

Created:
8 years, 3 months ago by boliu
Modified:
8 years, 3 months ago
Reviewers:
michaelbai, joth
CC:
chromium-reviews, android-webview-reviews_google.com
Visibility:
Public.

Description

Add android_gdbserver to android_webview* targets. There are other problems preventing android_experimental from building, but this fixes one issue. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=155267

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove android_toolchain #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M android_webview/android_webview.gyp View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
boliu
8 years, 3 months ago (2012-09-06 16:51:27 UTC) #1
michaelbai
https://chromiumcodereview.appspot.com/10909100/diff/1/android_webview/android_webview.gyp File android_webview/android_webview.gyp (right): https://chromiumcodereview.appspot.com/10909100/diff/1/android_webview/android_webview.gyp#newcode224 android_webview/android_webview.gyp:224: '-DANDROID_TOOLCHAIN=<(android_toolchain)', I submitted a CL to remove ANDROID_TOOLCHAIN, could ...
8 years, 3 months ago (2012-09-06 16:56:13 UTC) #2
boliu
On 2012/09/06 16:56:13, michaelbai wrote: > https://chromiumcodereview.appspot.com/10909100/diff/1/android_webview/android_webview.gyp > File android_webview/android_webview.gyp (right): > > https://chromiumcodereview.appspot.com/10909100/diff/1/android_webview/android_webview.gyp#newcode224 > ...
8 years, 3 months ago (2012-09-06 17:00:54 UTC) #3
michaelbai
lgtm
8 years, 3 months ago (2012-09-06 17:02:00 UTC) #4
joth
lgtm
8 years, 3 months ago (2012-09-06 17:04:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/boliu@chromium.org/10909100/3001
8 years, 3 months ago (2012-09-06 17:09:00 UTC) #6
commit-bot: I haz the power
Try job failure for 10909100-3001 (retry) on win_rel for step "runhooks". It's a second try, ...
8 years, 3 months ago (2012-09-06 19:01:41 UTC) #7
commit-bot: I haz the power
8 years, 3 months ago (2012-09-06 20:17:51 UTC) #8

Powered by Google App Engine
This is Rietveld 408576698