Issue 10909095: Delete images in Photo Editor

Issue 10909095: Delete images in Photo Editor (Closed)

Created:
8 years, 3 months ago by Vladislav Kaznacheev

Modified:
8 years, 3 months ago

Reviewers:
dgozman

CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, nkostylev+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, arv (Not doing code reviews), oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Delete images in Photo Editor First cut of the long awaited feature. There is no undo but there is a (quite out of style) confirmation dialog. BUG=129717 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=155398

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed comment, changed bg color, fixed an exception #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+67 lines, -8 lines)			Patch
M	chrome/browser/chromeos/extensions/file_browser_private_api.cc	View	1	1 chunk	+9 lines, -1 line	0 comments	Download
M	chrome/browser/resources/file_manager/css/gallery.css	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/file_manager/gallery.html	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/mock_chrome.js	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/photo/gallery.js	View	1	2 chunks	+46 lines, -7 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

dgozman

LGTM https://chromiumcodereview.appspot.com/10909095/diff/1/chrome/browser/resources/file_manager/js/photo/gallery.js File chrome/browser/resources/file_manager/js/photo/gallery.js (right): https://chromiumcodereview.appspot.com/10909095/diff/1/chrome/browser/resources/file_manager/js/photo/gallery.js#newcode397 chrome/browser/resources/file_manager/js/photo/gallery.js:397: var deleteNext = function() { You can define ...

8 years, 3 months ago (2012-09-07 10:02:20 UTC) #2

Vladislav Kaznacheev

PTAL https://chromiumcodereview.appspot.com/10909095/diff/1/chrome/browser/resources/file_manager/js/photo/gallery.js File chrome/browser/resources/file_manager/js/photo/gallery.js (right): https://chromiumcodereview.appspot.com/10909095/diff/1/chrome/browser/resources/file_manager/js/photo/gallery.js#newcode397 chrome/browser/resources/file_manager/js/photo/gallery.js:397: var deleteNext = function() { On 2012/09/07 10:02:20, ...

8 years, 3 months ago (2012-09-07 12:30:16 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/10909095/5001

8 years, 3 months ago (2012-09-07 13:39:32 UTC) #5

commit-bot: I haz the power

8 years, 3 months ago (2012-09-07 14:27:00 UTC) #6

Try job failure for 10909095-5001 (retry) on linux_rel for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Expand Messages | Collapse Messages