runtime/bin/http_impl.dart - Issue 10909057: Use correct cookie date parsing for cookie 'expires' field.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/http_impl.dart

Issue 10909057: Use correct cookie date parsing for cookie 'expires' field. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Review update. Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/bin/http_impl.dart

diff --git a/runtime/bin/http_impl.dart b/runtime/bin/http_impl.dart

index 25a448c970f8d2b806dd4e7139cb3047baace162..9b9a46d1f79b1662d4c1a691cb62c6dd49b5468e 100644

--- a/runtime/bin/http_impl.dart

+++ b/runtime/bin/http_impl.dart

@@ -534,7 +534,7 @@ class _Cookie implements Cookie {

value = parseAttributeValue();

}

if (name == "expires") {

- expires = _HttpUtils.parseDate(value, strict: false);

+ expires = _HttpUtils.parseCookieDate(value);

} else if (name == "max-age") {

maxAge = parseInt(value);

} else if (name == "domain") {

« no previous file with comments | « no previous file | runtime/bin/http_utils.dart » ('j') | runtime/bin/http_utils.dart » ('J')