Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10909043: Cancel drag if display configuration changes. (Closed)

Created:
8 years, 3 months ago by oshima
Modified:
8 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, mazda+watch_chromium.org, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org, ben+watch_chromium.org
Visibility:
Public.

Description

Cancel drag if display configuration changes. * Removed debug specific shortcut to emulate display change. * fixed ui_controls to use the correct position * a few minor clean ups (removing unnecessary namesapce, rename Monitor -> Display) BUG=14457 TEST=covered by test Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155762 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=155975

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2

Patch Set 5 : test #

Patch Set 6 : new patch #

Patch Set 7 : #

Patch Set 8 : win fix, adjust test screen size #

Total comments: 6

Patch Set 9 : #

Patch Set 10 : resync #

Patch Set 11 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+409 lines, -123 lines) Patch
M ash/accelerators/accelerator_controller.cc View 1 2 3 4 5 6 7 8 9 4 chunks +18 lines, -19 lines 0 comments Download
M ash/accelerators/accelerator_table.h View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M ash/accelerators/accelerator_table.cc View 1 2 3 4 2 chunks +0 lines, -4 lines 0 comments Download
M ash/display/display_controller.h View 1 2 3 4 5 6 7 8 9 5 chunks +20 lines, -0 lines 0 comments Download
M ash/display/display_controller.cc View 1 2 3 4 5 chunks +34 lines, -10 lines 0 comments Download
M ash/display/display_controller_unittest.cc View 1 2 3 4 5 6 4 chunks +39 lines, -1 line 0 comments Download
M ash/display/multi_display_manager.h View 1 2 3 4 5 6 7 8 9 2 chunks +0 lines, -2 lines 0 comments Download
M ash/display/multi_display_manager.cc View 1 2 3 4 5 6 7 8 9 5 chunks +9 lines, -23 lines 0 comments Download
M ash/display/multi_display_manager_unittest.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +4 lines, -13 lines 0 comments Download
M ash/root_window_controller.h View 1 2 3 4 5 6 1 chunk +6 lines, -0 lines 0 comments Download
M ash/root_window_controller.cc View 1 2 3 4 5 6 7 8 9 10 3 chunks +12 lines, -1 line 0 comments Download
M ash/ui_controls_ash.cc View 1 2 3 4 chunks +29 lines, -21 lines 0 comments Download
M ash/wm/toplevel_window_event_handler.h View 1 2 3 4 5 6 7 8 9 10 4 chunks +13 lines, -3 lines 0 comments Download
M ash/wm/toplevel_window_event_handler.cc View 1 2 3 4 5 6 7 8 9 10 4 chunks +19 lines, -3 lines 0 comments Download
M ash/wm/toplevel_window_event_handler_unittest.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_window_resizer_unittest.cc View 1 2 3 4 5 6 7 8 9 3 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc View 1 2 3 4 5 6 7 8 3 chunks +149 lines, -2 lines 0 comments Download
M ui/aura/client/window_move_client.h View 1 2 3 1 chunk +9 lines, -1 line 0 comments Download
M ui/aura/root_window.h View 1 2 3 4 5 6 7 8 1 chunk +3 lines, -0 lines 0 comments Download
M ui/aura/root_window.cc View 1 2 3 4 5 6 7 8 1 chunk +6 lines, -0 lines 0 comments Download
M ui/aura/root_window_host.h View 1 2 3 4 5 6 7 8 1 chunk +3 lines, -0 lines 0 comments Download
M ui/aura/root_window_host_linux.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura/root_window_host_linux.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +4 lines, -0 lines 0 comments Download
M ui/aura/root_window_host_win.h View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura/root_window_host_win.cc View 1 2 3 4 5 6 7 8 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_root_window_host_win.h View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/desktop_root_window_host_win.cc View 1 2 3 4 5 6 7 8 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/widget/native_widget_aura.cc View 1 2 3 4 5 6 7 8 1 chunk +4 lines, -3 lines 0 comments Download
M ui/views/widget/x11_desktop_window_move_client.h View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M ui/views/widget/x11_desktop_window_move_client.cc View 1 2 3 3 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
oshima
ping?
8 years, 3 months ago (2012-09-05 21:26:53 UTC) #1
sky
http://codereview.chromium.org/10909043/diff/7005/ash/display/display_controller.h File ash/display/display_controller.h (right): http://codereview.chromium.org/10909043/diff/7005/ash/display/display_controller.h#newcode71 ash/display/display_controller.h:71: }; protected virtual destructor. http://codereview.chromium.org/10909043/diff/7005/ash/wm/toplevel_window_event_filter.cc File ash/wm/toplevel_window_event_filter.cc (right): http://codereview.chromium.org/10909043/diff/7005/ash/wm/toplevel_window_event_filter.cc#newcode259 ...
8 years, 3 months ago (2012-09-05 22:45:36 UTC) #2
oshima
Uploaded new pathc, so ptal. I added StopListeningEvents method instead of deleting host window because ...
8 years, 3 months ago (2012-09-08 00:40:43 UTC) #3
sky
LGTM https://chromiumcodereview.appspot.com/10909043/diff/32/ash/display/display_controller.h File ash/display/display_controller.h (right): https://chromiumcodereview.appspot.com/10909043/diff/32/ash/display/display_controller.h#newcode71 ash/display/display_controller.h:71: }; protected virtual destructor. https://chromiumcodereview.appspot.com/10909043/diff/32/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc File chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc (right): ...
8 years, 3 months ago (2012-09-10 14:11:36 UTC) #4
oshima
https://chromiumcodereview.appspot.com/10909043/diff/32/ash/display/display_controller.h File ash/display/display_controller.h (right): https://chromiumcodereview.appspot.com/10909043/diff/32/ash/display/display_controller.h#newcode71 ash/display/display_controller.h:71: }; On 2012/09/10 14:11:37, sky wrote: > protected virtual ...
8 years, 3 months ago (2012-09-10 15:49:11 UTC) #5
oshima
8 years, 3 months ago (2012-09-10 15:49:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/10909043/10052
8 years, 3 months ago (2012-09-10 15:57:33 UTC) #7
commit-bot: I haz the power
8 years, 3 months ago (2012-09-10 17:54:45 UTC) #8 
Change committed as 155762

Powered by Google App Engine
This is Rietveld 408576698