Make history page touch friendly.

Make history page touch friendly.

BUG=115236
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=154877

[kevers, 2012-08-31 18:39:14]

Hi Evan,

Can you please have a look at this CL.

[Evan Stade, 2012-08-31 18:42:55]

code lgtm assuming some UI lead has approved the idea.

[Evan Stade, 2012-08-31 18:43:00]

http://codereview.chromium.org/10909031/diff/1/chrome/browser/resources/histo...
File chrome/browser/resources/history/history.css (right):

http://codereview.chromium.org/10909031/diff/1/chrome/browser/resources/histo...
chrome/browser/resources/history/history.css:232: 
^H

[dubroy1, 2012-08-31 18:44:39]

Are we sure we want to make these changes on all platforms?

On 2012/08/31 18:43:00, Evan Stade wrote:
>
http://codereview.chromium.org/10909031/diff/1/chrome/browser/resources/histo...
> File chrome/browser/resources/history/history.css (right):
> 
>
http://codereview.chromium.org/10909031/diff/1/chrome/browser/resources/histo...
> chrome/browser/resources/history/history.css:232: 
> ^H

[kevers, 2012-08-31 18:46:41]

On 2012/08/31 18:44:39, dubroy1 wrote:
> Are we sure we want to make these changes on all platforms?
> 
> On 2012/08/31 18:43:00, Evan Stade wrote:
> >
>
http://codereview.chromium.org/10909031/diff/1/chrome/browser/resources/histo...
> > File chrome/browser/resources/history/history.css (right):
> > 
> >
>
http://codereview.chromium.org/10909031/diff/1/chrome/browser/resources/histo...
> > chrome/browser/resources/history/history.css:232: 
> > ^H

Yes, the change is intended for all platforms.  There has been a deliberate
effort to unify the WebUI for touch and non-touch.

[Patrick Dubroy, 2012-09-03 13:31:35]

On 2012/08/31 18:46:41, kevers wrote:
> On 2012/08/31 18:44:39, dubroy1 wrote:
> > Are we sure we want to make these changes on all platforms?
> > 
> > On 2012/08/31 18:43:00, Evan Stade wrote:
> > >
> >
>
http://codereview.chromium.org/10909031/diff/1/chrome/browser/resources/histo...
> > > File chrome/browser/resources/history/history.css (right):
> > > 
> > >
> >
>
http://codereview.chromium.org/10909031/diff/1/chrome/browser/resources/histo...
> > > chrome/browser/resources/history/history.css:232: 
> > > ^H
> 
> Yes, the change is intended for all platforms.  There has been a deliberate
> effort to unify the WebUI for touch and non-touch.

I took a look at chrome://settings, and it appears that only Windows and
ChromeOS have the increased spacing. If MacOS isn't getting the increased
spacing on settings, it also shouldn't have it on the history page.

[kevers, 2012-09-04 15:18:26]

On 2012/09/03 13:31:35, dubroy wrote:
> On 2012/08/31 18:46:41, kevers wrote:
> > On 2012/08/31 18:44:39, dubroy1 wrote:
> > > Are we sure we want to make these changes on all platforms?
> > > 
> > > On 2012/08/31 18:43:00, Evan Stade wrote:
> > > >
> > >
> >
>
http://codereview.chromium.org/10909031/diff/1/chrome/browser/resources/histo...
> > > > File chrome/browser/resources/history/history.css (right):
> > > > 
> > > >
> > >
> >
>
http://codereview.chromium.org/10909031/diff/1/chrome/browser/resources/histo...
> > > > chrome/browser/resources/history/history.css:232: 
> > > > ^H
> > 
> > Yes, the change is intended for all platforms.  There has been a deliberate
> > effort to unify the WebUI for touch and non-touch.
> 
> I took a look at chrome://settings, and it appears that only Windows and
> ChromeOS have the increased spacing. If MacOS isn't getting the increased
> spacing on settings, it also shouldn't have it on the history page.

@media queries for touch screens has been removed from the settings page and the
sizes consolidated for touch and non-touch.  Surprised that you are seeing less
spacing on MacOS.  While it was true a while ago that only Windows and ChromeOS
had increased spacing for touch, this restriction has recently been removed.  

There is one remaining bit of unification work that I am aware of, namely the
height of entries in popup menus.  I patch for popup menus
(https://bugs.webkit.org/show_bug.cgi?id=95606) has been reviewed as is expected
to land shortly.

[commit-bot: I haz the power, 2012-09-04 16:02:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kevers@chromium.org/10909031/4002

[commit-bot: I haz the power, 2012-09-04 17:16:18]

Try job failure for 10909031-4002 (retry) on linux_rel for step
"interactive_ui_tests" (clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2012-09-04 23:41:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kevers@chromium.org/10909031/4002

[commit-bot: I haz the power, 2012-09-05 01:47:16]

Change committed as 154877