src/ia32/macro-assembler-ia32.h - Issue 10909007: Sharing of descriptor arrays.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/macro-assembler-ia32.h

Issue 10909007: Sharing of descriptor arrays. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Ensure descriptor arrays are not shared acrossed severed transition chains. Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ia32/macro-assembler-ia32.h

diff --git a/src/ia32/macro-assembler-ia32.h b/src/ia32/macro-assembler-ia32.h

index 7d475e7d7edf0b0462c72a8b45f9ddbe41409b17..909000ec011263a37c0182529c9f916da1df972a 100644

--- a/src/ia32/macro-assembler-ia32.h

+++ b/src/ia32/macro-assembler-ia32.h

@@ -493,13 +493,14 @@ class MacroAssembler: public Assembler {

void LoadInstanceDescriptors(Register map, Register descriptors);

void EnumLength(Register dst, Register map);

+ void NumberOfOwnDescriptors(Register dst, Register map);

template<typename Field>

void DecodeField(Register reg) {

- static const int full_shift = Field::kShift + kSmiTagSize;

- static const int low_mask = Field::kMask >> Field::kShift;

- sar(reg, full_shift);

- and_(reg, Immediate(low_mask));

+ static const int shift = Field::kShift;

+ static const int mask = (Field::kMask >> Field::kShift) << kSmiTagSize;

+ sar(reg, shift);

+ and_(reg, Immediate(mask));

}

void LoadPowerOf2(XMMRegister dst, Register scratch, int power);