[cros] disable GDrive option on certain file pickers

[cros] disable GDrive option on certain file pickers

This disables the GDrive folder for features that don't support reading/writing gdata. See bug for complete list.

BUG=149184
TEST=manual (all pickers listed on bug under "doesn't work", no longer shows gdrive, others still do)


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157012

[Evan Stade, 2012-09-14 14:27:03]

zvorygin - file manager
thakis - mac
sky - everything else (particularly ui/base/)

This looks like a large review but most files only have one or two lines
changed. The fact I had to put a variable called supports_gdata in ui/base/ is a
layering violation which makes me sad but I don't see a better way that doesn't
require a larger refactoring.

This change is targeted at m23. If you feel there is a better reviewer or you
can not get to this review quickly, kindly find another reviewer to take your
part.

http://codereview.chromium.org/10908262/diff/2002/chrome/browser/ui/libgtk2ui...
File chrome/browser/ui/libgtk2ui/select_file_dialog_impl_gtk2.cc (left):

http://codereview.chromium.org/10908262/diff/2002/chrome/browser/ui/libgtk2ui...
chrome/browser/ui/libgtk2ui/select_file_dialog_impl_gtk2.cc:225:
file_types_.include_all_files = true;
not necessary due to L305

http://codereview.chromium.org/10908262/diff/2002/chrome/browser/ui/libgtk2ui...
File chrome/browser/ui/libgtk2ui/select_file_dialog_impl_gtk2.cc (right):

http://codereview.chromium.org/10908262/diff/2002/chrome/browser/ui/libgtk2ui...
chrome/browser/ui/libgtk2ui/select_file_dialog_impl_gtk2.cc:305: if
(file_types_.include_all_files && !file_types_.extensions.empty()) {
(we ignore that include_all_files was set to true)

http://codereview.chromium.org/10908262/diff/2002/ui/base/dialogs/select_file...
File ui/base/dialogs/select_file_dialog_mac.mm (right):

http://codereview.chromium.org/10908262/diff/2002/ui/base/dialogs/select_file...
ui/base/dialogs/select_file_dialog_mac.mm:238: if (file_types->include_all_files
|| file_types->extensions.empty())
quite similar to L247

[Dmitry Zvorygin, 2012-09-14 15:55:27]

http://codereview.chromium.org/10908262/diff/2002/chrome/browser/resources/fi...
File chrome/browser/resources/file_manager/js/file_manager.js (right):

http://codereview.chromium.org/10908262/diff/2002/chrome/browser/resources/fi...
chrome/browser/resources/file_manager/js/file_manager.js:2417: return
this.params_.supportGData &&
Consider using opposite value - disableGData, because one can easily open file
manager just typing 'chrome://files' in url bar - and he will have GData
disabled by default, which is quite curious, isn't it?

[Evan Stade, 2012-09-14 16:25:12]

http://codereview.chromium.org/10908262/diff/2002/chrome/browser/resources/fi...
File chrome/browser/resources/file_manager/js/file_manager.js (right):

http://codereview.chromium.org/10908262/diff/2002/chrome/browser/resources/fi...
chrome/browser/resources/file_manager/js/file_manager.js:2417: return
this.params_.supportGData &&
On 2012/09/14 15:55:27, Dmitry Zvorygin wrote:
> Consider using opposite value - disableGData, because one can easily open file
> manager just typing 'chrome://files' in url bar - and he will have GData
> disabled by default, which is quite curious, isn't it?

Done.

[Dmitry Zvorygin, 2012-09-14 16:27:23]

On 2012/09/14 16:25:12, Evan Stade wrote:
>
http://codereview.chromium.org/10908262/diff/2002/chrome/browser/resources/fi...
> File chrome/browser/resources/file_manager/js/file_manager.js (right):
> 
>
http://codereview.chromium.org/10908262/diff/2002/chrome/browser/resources/fi...
> chrome/browser/resources/file_manager/js/file_manager.js:2417: return
> this.params_.supportGData &&
> On 2012/09/14 15:55:27, Dmitry Zvorygin wrote:
> > Consider using opposite value - disableGData, because one can easily open
file
> > manager just typing 'chrome://files' in url bar - and he will have GData
> > disabled by default, which is quite curious, isn't it?
> 
> Done.

LGTM for file_manager.js

[sky, 2012-09-14 17:10:57]

LGTM

[vandebo (ex-Chrome), 2012-09-14 17:30:41]

+mark can you proxy for thakis since it's already the weekend in his current
timezone?

[Mark Mentovai, 2012-09-14 17:37:04]

thakis-channeling LGTM

[commit-bot: I haz the power, 2012-09-14 22:10:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/estade@chromium.org/10908262/1019

[commit-bot: I haz the power, 2012-09-15 17:39:08]

Commit queue patch verification failed without an error message.
Something went wrong, probably a crash, a hickup or simply
the monkeys went out for dinner.
Ping the relevant dude on a on-needed basis.

[commit-bot: I haz the power, 2012-09-15 17:39:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/estade@chromium.org/10908262/1019

[commit-bot: I haz the power, 2012-09-15 20:15:54]

Change committed as 157012