Issue 10908254: NaCl: Remove the only use of NACL_ARCH_CPU_* #defines

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10908254: NaCl: Remove the only use of NACL_ARCH_CPU_* #defines (Closed)

Created:
8 years, 3 months ago by Mark Seaborn

Modified:
8 years, 3 months ago

Reviewers:
Nick Bray, bradn

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

NaCl: Remove the only use of NACL_ARCH_CPU_* #defines Use NACL_BUILD_ARCH/SUBARCH instead, since that is the usual way of checking the architecture in NaCl code. BUG=none TEST=trybots Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=156827

Patch Set 1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	ppapi/native_client/src/trusted/plugin/arch_x86/sandbox_isa.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages