Moving the WhitenessWitness back to DescriptorArray.

src/transitions-inl.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 182 matching lines @@
   int descriptor = map->LastAdded();
   return descriptors->GetDetails(descriptor);
 }
 
 
 int TransitionArray::Search(String* name) {
   return internal::Search<ALL_ENTRIES>(this, name);
 }
 
 
-void TransitionArray::Set(int transition_number,
-                          String* key,
-                          Map* target,
-                          const WhitenessWitness&) {
-  NoIncrementalWriteBarrierSet(this,
-                               ToKeyIndex(transition_number),
-                               key);
-  NoIncrementalWriteBarrierSet(this,
-                               ToTargetIndex(transition_number),
-                               target);
+void TransitionArray::Set(int transition_number, String* key, Map* target) {

[Michael Starzinger, 2012/09/14 11:18:08]

Now that this method no longer takes a WhitenessWitness we need to rename this
method to NoIncrementalWriteBarrierSet() so that it is clear that we can only
call this on white objects. Otherwise this will become a bucket of bugs.

[Toon Verwaest, 2012/09/14 12:28:04]

Done.

+  NoIncrementalWriteBarrierSet(this, ToKeyIndex(transition_number), key);
+  NoIncrementalWriteBarrierSet(this, ToTargetIndex(transition_number), target);
 }
 
 
 #undef FIELD_ADDR
 #undef WRITE_FIELD
 #undef CONDITIONAL_WRITE_BARRIER
 
 
 } }  // namespace v8::internal
 
 #endif  // V8_TRANSITIONS_INL_H_