Convert static error to warning for calls to toplevel methods, getters and setters.

tests/language/call_nonexistent_static_test.dart

Index: tests/language/call_nonexistent_static_test.dart
diff --git a/tests/language/call_nonexistent_static_test.dart b/tests/language/call_nonexistent_static_test.dart
index 4eb206a4d1f7b865eff404c4d5e02a0a9fdc299b..beae6f8363d131a9e39842c9cf43bf538279184a 100644
--- a/tests/language/call_nonexistent_static_test.dart
+++ b/tests/language/call_nonexistent_static_test.dart
@@ -7,8 +7,23 @@
 
 class C {}
 
+class D {
+  get hest => 1;  /// 04: continued
+  set hest(val) {}  /// 05: continued
+}
+
+get fisk => 2; /// 09: continued
+set fisk(val) {} /// 10: continued
+
 main() {
   Expect.throws(() => C.hest = 1, (e) => e is NoSuchMethodError); /// 01: static type warning
   Expect.throws(() => C.hest, (e) => e is NoSuchMethodError);     /// 02: static type warning
   Expect.throws(() => C.hest(), (e) => e is NoSuchMethodError);   /// 03: static type warning
+  Expect.throws(() => D.hest = 1, (e) => e is NoSuchMethodError); /// 04: static type warning

[ahe, 2012/09/13 12:31:14]

Line is longer than 80 columns.

Which reveals an error with this approach. The static warning, I presume is on
D.hest = 1, but there is nothing wrong with the rest of the expression.

So this is a poor test of static warnings.

[karlklose, 2012/09/13 13:47:26]

I changed the test.

+  Expect.throws(() => D.hest, (e) => e is NoSuchMethodError);     /// 05: static type warning
+  Expect.throws(() => fisk = 1, (e) => e is NoSuchMethodError);   /// 06: static type warning
+  Expect.throws(() => fisk, (e) => e is NoSuchMethodError);       /// 07: static type warning
+  Expect.throws(() => fisk(), (e) => e is NoSuchMethodError);     /// 08: static type warning
+  Expect.throws(() => fisk = 1, (e) => e is NoSuchMethodError);   /// 09: static type warning
+  Expect.throws(() => fisk, (e) => e is NoSuchMethodError);       /// 10: static type warning
 }