Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issue 10908216: Ensure correct enumeration indices in the dict (Closed)

Created:
8 years, 3 months ago by Toon Verwaest
Modified:
8 years, 3 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Ensure correct enumeration indices in the dict BUG=chromium:148376 Committed: https://code.google.com/p/v8/source/detail?r=12494

Patch Set 1 #

Total comments: 3

Patch Set 2 : Removed elements case #

Total comments: 1

Patch Set 3 : Addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -12 lines) Patch
M src/objects.cc View 1 2 1 chunk +13 lines, -4 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-148376.js View 1 1 chunk +6 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Toon Verwaest
PTAL.
8 years, 3 months ago (2012-09-12 16:23:13 UTC) #1
Michael Starzinger
https://chromiumcodereview.appspot.com/10908216/diff/1/src/objects.cc File src/objects.cc (right): https://chromiumcodereview.appspot.com/10908216/diff/1/src/objects.cc#newcode9405 src/objects.cc:9405: if (details.dictionary_index() == 0 && !(attributes & DONT_ENUM)) { ...
8 years, 3 months ago (2012-09-12 17:06:55 UTC) #2
Toon Verwaest
Removed the elements-related code. Also removed the ASSERT from DetailsAtPut since it should not trigger ...
8 years, 3 months ago (2012-09-13 08:46:32 UTC) #3
Michael Starzinger
8 years, 3 months ago (2012-09-13 08:51:17 UTC) #4
LGTM.

https://chromiumcodereview.appspot.com/10908216/diff/2002/src/objects.cc
File src/objects.cc (right):

https://chromiumcodereview.appspot.com/10908216/diff/2002/src/objects.cc#newc...
src/objects.cc:499: ASSERT(enumeration_index != 0);
We could assert for enumeration_index > 0 here. Just a nit, feel free to ignore.

Powered by Google App Engine
This is Rietveld 408576698