Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Side by Side Diff: src/lithium.h

Issue 10908194: Fix arguments object materialization during deopt. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Improved test coverage and fixed bug. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/lithium-ia32.cc ('k') | src/mips/lithium-codegen-mips.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 442 matching lines...) Expand 10 before | Expand all | Expand 10 after
453 453
454 class LEnvironment: public ZoneObject { 454 class LEnvironment: public ZoneObject {
455 public: 455 public:
456 LEnvironment(Handle<JSFunction> closure, 456 LEnvironment(Handle<JSFunction> closure,
457 FrameType frame_type, 457 FrameType frame_type,
458 BailoutId ast_id, 458 BailoutId ast_id,
459 int parameter_count, 459 int parameter_count,
460 int argument_count, 460 int argument_count,
461 int value_count, 461 int value_count,
462 LEnvironment* outer, 462 LEnvironment* outer,
463 HEnterInlined* entry,
463 Zone* zone) 464 Zone* zone)
464 : closure_(closure), 465 : closure_(closure),
465 frame_type_(frame_type), 466 frame_type_(frame_type),
466 arguments_stack_height_(argument_count), 467 arguments_stack_height_(argument_count),
467 deoptimization_index_(Safepoint::kNoDeoptimizationIndex), 468 deoptimization_index_(Safepoint::kNoDeoptimizationIndex),
468 translation_index_(-1), 469 translation_index_(-1),
469 ast_id_(ast_id), 470 ast_id_(ast_id),
470 parameter_count_(parameter_count), 471 parameter_count_(parameter_count),
471 pc_offset_(-1), 472 pc_offset_(-1),
472 values_(value_count, zone), 473 values_(value_count, zone),
473 is_tagged_(value_count, zone), 474 is_tagged_(value_count, zone),
474 is_uint32_(value_count, zone), 475 is_uint32_(value_count, zone),
475 spilled_registers_(NULL), 476 spilled_registers_(NULL),
476 spilled_double_registers_(NULL), 477 spilled_double_registers_(NULL),
477 outer_(outer), 478 outer_(outer),
479 entry_(entry),
478 zone_(zone) { } 480 zone_(zone) { }
479 481
480 Handle<JSFunction> closure() const { return closure_; } 482 Handle<JSFunction> closure() const { return closure_; }
481 FrameType frame_type() const { return frame_type_; } 483 FrameType frame_type() const { return frame_type_; }
482 int arguments_stack_height() const { return arguments_stack_height_; } 484 int arguments_stack_height() const { return arguments_stack_height_; }
483 int deoptimization_index() const { return deoptimization_index_; } 485 int deoptimization_index() const { return deoptimization_index_; }
484 int translation_index() const { return translation_index_; } 486 int translation_index() const { return translation_index_; }
485 BailoutId ast_id() const { return ast_id_; } 487 BailoutId ast_id() const { return ast_id_; }
486 int parameter_count() const { return parameter_count_; } 488 int parameter_count() const { return parameter_count_; }
487 int pc_offset() const { return pc_offset_; } 489 int pc_offset() const { return pc_offset_; }
488 LOperand** spilled_registers() const { return spilled_registers_; } 490 LOperand** spilled_registers() const { return spilled_registers_; }
489 LOperand** spilled_double_registers() const { 491 LOperand** spilled_double_registers() const {
490 return spilled_double_registers_; 492 return spilled_double_registers_;
491 } 493 }
492 const ZoneList<LOperand*>* values() const { return &values_; } 494 const ZoneList<LOperand*>* values() const { return &values_; }
493 LEnvironment* outer() const { return outer_; } 495 LEnvironment* outer() const { return outer_; }
496 HEnterInlined* entry() { return entry_; }
494 497
495 void AddValue(LOperand* operand, 498 void AddValue(LOperand* operand,
496 Representation representation, 499 Representation representation,
497 bool is_uint32) { 500 bool is_uint32) {
498 values_.Add(operand, zone()); 501 values_.Add(operand, zone());
499 if (representation.IsTagged()) { 502 if (representation.IsTagged()) {
500 ASSERT(!is_uint32); 503 ASSERT(!is_uint32);
501 is_tagged_.Add(values_.length() - 1); 504 is_tagged_.Add(values_.length() - 1);
502 } 505 }
503 506
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
549 BitVector is_tagged_; 552 BitVector is_tagged_;
550 BitVector is_uint32_; 553 BitVector is_uint32_;
551 554
552 // Allocation index indexed arrays of spill slot operands for registers 555 // Allocation index indexed arrays of spill slot operands for registers
553 // that are also in spill slots at an OSR entry. NULL for environments 556 // that are also in spill slots at an OSR entry. NULL for environments
554 // that do not correspond to an OSR entry. 557 // that do not correspond to an OSR entry.
555 LOperand** spilled_registers_; 558 LOperand** spilled_registers_;
556 LOperand** spilled_double_registers_; 559 LOperand** spilled_double_registers_;
557 560
558 LEnvironment* outer_; 561 LEnvironment* outer_;
562 HEnterInlined* entry_;
559 563
560 Zone* zone_; 564 Zone* zone_;
561 }; 565 };
562 566
563 567
564 // Iterates over the non-null, non-constant operands in an environment. 568 // Iterates over the non-null, non-constant operands in an environment.
565 class ShallowIterator BASE_EMBEDDED { 569 class ShallowIterator BASE_EMBEDDED {
566 public: 570 public:
567 explicit ShallowIterator(LEnvironment* env) 571 explicit ShallowIterator(LEnvironment* env)
568 : env_(env), 572 : env_(env),
(...skipping 128 matching lines...) Expand 10 before | Expand all | Expand 10 after
697 ZoneList<Handle<JSFunction> > inlined_closures_; 701 ZoneList<Handle<JSFunction> > inlined_closures_;
698 }; 702 };
699 703
700 704
701 int ElementsKindToShiftSize(ElementsKind elements_kind); 705 int ElementsKindToShiftSize(ElementsKind elements_kind);
702 706
703 707
704 } } // namespace v8::internal 708 } } // namespace v8::internal
705 709
706 #endif // V8_LITHIUM_H_ 710 #endif // V8_LITHIUM_H_
OLDNEW
« no previous file with comments | « src/ia32/lithium-ia32.cc ('k') | src/mips/lithium-codegen-mips.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698