Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(874)

Unified Diff: dart/pkg/unittest/test_controller.js

Issue 10908193: Do not call showErrorAndExit "out" of order (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/pkg/unittest/test_controller.js
diff --git a/dart/pkg/unittest/test_controller.js b/dart/pkg/unittest/test_controller.js
index 3698b3e95588b79e7b0c289939c5829ff1ba6a40..0f797d0e70ab7b426ac1cf238347b26ce86e1df4 100644
--- a/dart/pkg/unittest/test_controller.js
+++ b/dart/pkg/unittest/test_controller.js
@@ -112,10 +112,6 @@ function dartMainRunner(main) {
try {
main();
} catch (e) {
- showErrorAndExit(String(e));
- // Calling showErrorAndExit will not call testRunner.notifyDone()
- // at this point. This is because of the async nature of this framework.
- // testRunner.startedDartTest is not true yet. So post a message.
window.postMessage('unittest-suite-fail', '*');
return; // Posting 'dart-main-done' signals success.
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698