Issue 10908180: Reset 'can_update_offset' on call to ChunkDemuxer::Abort()

Issue 10908180: Reset 'can_update_offset' on call to ChunkDemuxer::Abort() (Closed)

Created:
8 years, 3 months ago by strobe_

Modified:
8 years, 3 months ago

Reviewers:
acolwell GONE FROM CHROMIUM

CC:
chromium-reviews, feature-media-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Reset 'can_update_offset' on call to ChunkDemuxer::Abort() BUG= TEST=ChunkDemuxerTest::TestTimestampOffsetMidParse Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156040

Patch Set 3 : Really fix comment #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	media/filters/chunk_demuxer.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	media/filters/chunk_demuxer_unittest.cc	View	1 2	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

acolwell GONE FROM CHROMIUM

LGTM https://chromiumcodereview.appspot.com/10908180/diff/1/media/filters/chunk_demuxer_unittest.cc File media/filters/chunk_demuxer_unittest.cc (right): https://chromiumcodereview.appspot.com/10908180/diff/1/media/filters/chunk_demuxer_unittest.cc#newcode2265 media/filters/chunk_demuxer_unittest.cc:2265: // After reset, setting a timestamp should succeed ...

8 years, 3 months ago (2012-09-11 11:31:45 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/strobe@google.com/10908180/5001

8 years, 3 months ago (2012-09-11 14:25:00 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/strobe@google.com/10908180/11001

8 years, 3 months ago (2012-09-11 14:26:17 UTC) #4

strobe_

https://chromiumcodereview.appspot.com/10908180/diff/1/media/filters/chunk_demuxer_unittest.cc File media/filters/chunk_demuxer_unittest.cc (right): https://chromiumcodereview.appspot.com/10908180/diff/1/media/filters/chunk_demuxer_unittest.cc#newcode2265 media/filters/chunk_demuxer_unittest.cc:2265: // After reset, setting a timestamp should succeed since ...

8 years, 3 months ago (2012-09-11 14:26:53 UTC) #5

Change committed as 156040

Expand Messages | Collapse Messages