Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(709)

Issue 10908177: Removed DCHECK. (Closed)

Created:
8 years, 3 months ago by Vitaly Buka (NO REVIEWS)
Modified:
8 years, 3 months ago
Reviewers:
greggman, jbates
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium
Visibility:
Public.

Description

Removed DCHECK. This DCHECK fails often during debugging. BUG=147329 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155956

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M content/common/gpu/image_transport_surface_win.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Vitaly Buka (NO REVIEWS)
Please let me remove this annoying DCHECK.
8 years, 3 months ago (2012-09-10 22:34:13 UTC) #1
jbates
Interesting, this may be the cause of http://code.google.com/p/chromium/issues/detail?id=147329. Please set 147329 as the BUG= just ...
8 years, 3 months ago (2012-09-10 22:54:45 UTC) #2
Vitaly Buka (NO REVIEWS)
https://chromiumcodereview.appspot.com/10908177/diff/1/content/common/gpu/image_transport_surface_win.cc File content/common/gpu/image_transport_surface_win.cc (left): https://chromiumcodereview.appspot.com/10908177/diff/1/content/common/gpu/image_transport_surface_win.cc#oldcode121 content/common/gpu/image_transport_surface_win.cc:121: DCHECK(!did_unschedule_); On 2012/09/10 22:54:45, jbates wrote: > If this ...
8 years, 3 months ago (2012-09-10 22:59:51 UTC) #3
jbates
LGTM
8 years, 3 months ago (2012-09-10 23:05:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/10908177/4001
8 years, 3 months ago (2012-09-10 23:37:59 UTC) #5
commit-bot: I haz the power
Failed to apply patch for content/common/gpu/image_transport_surface_win.cc: While running patch -p1 --forward --force; patching file content/common/gpu/image_transport_surface_win.cc ...
8 years, 3 months ago (2012-09-10 23:38:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/10908177/11001
8 years, 3 months ago (2012-09-10 23:40:34 UTC) #7
commit-bot: I haz the power
Presubmit check for 10908177-11001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 3 months ago (2012-09-10 23:40:40 UTC) #8
greggman
LGTM
8 years, 3 months ago (2012-09-11 01:14:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/10908177/11001
8 years, 3 months ago (2012-09-11 02:27:39 UTC) #10
commit-bot: I haz the power
8 years, 3 months ago (2012-09-11 05:56:17 UTC) #11
Change committed as 155956

Powered by Google App Engine
This is Rietveld 408576698