Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 10908166: Font Settings API: Sample Extension minor UI improvements (Closed)

Created:
8 years, 3 months ago by falken
Modified:
8 years, 3 months ago
Reviewers:
Matt Perry
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

Font Settings API: Sample Extension minor UI improvements Use input type=number and let font size settings affect only the sample texts. BUG=114805 TBR=mpcomplete Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155675

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -22 lines) Patch
M chrome/common/extensions/docs/examples/api/fontSettings/css/widgets.css View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/fontSettings/options.html View 3 chunks +14 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/fontSettings/options.js View 2 chunks +28 lines, -17 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
falken
8 years, 3 months ago (2012-09-10 04:27:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/falken@chromium.org/10908166/1
8 years, 3 months ago (2012-09-10 04:28:35 UTC) #2
commit-bot: I haz the power
Change committed as 155675
8 years, 3 months ago (2012-09-10 07:06:13 UTC) #3
Matt Perry
8 years, 3 months ago (2012-09-10 19:03:29 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698