Issue 10908151: aura: Fix focus on web contents for popup windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10908151: aura: Fix focus on web contents for popup windows (Closed)

Created:
8 years, 3 months ago by James Cook

Modified:
8 years, 3 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

aura: Fix focus on web contents for popup windows On Aura when the BrowserView attempts to set focus during its setup it is blocked because this parent BrowserFrameAura isn't yet visible. This means the RenderWidgetHostViewAura doesn't gain focus, so JavaScript calls to element.focus() don't result in being able to type into a field. This was affecting chat apps that open popups for chat sessions. Fixed by calling BrowserView::RestoreFocus() when the browser's window becomes visible. BUG=144342 TEST=existing focus tests, sample pages in bug, manual exercise of focus in location bar and web page during window creation and show/hide during minimize/restore Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155791

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -0 lines)			Patch
	M	chrome/browser/ui/views/frame/browser_frame_aura.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
	M	chrome/browser/ui/views/frame/browser_frame_aura.cc	View	1 2	1 chunk	+11 lines, -0 lines	0 comments	Download