lib/compiler/implementation/enqueue.dart - Issue 10908142: Add runtimeType() to Object which returns canonicalized instances of Type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/compiler/implementation/enqueue.dart

Issue 10908142: Add runtimeType() to Object which returns canonicalized instances of Type. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « lib/compiler/implementation/compiler.dart ('k') | lib/compiler/implementation/js_backend/emitter.dart » ('j') | lib/compiler/implementation/lib/js_helper.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: lib/compiler/implementation/enqueue.dart

diff --git a/lib/compiler/implementation/enqueue.dart b/lib/compiler/implementation/enqueue.dart

index 6d6f40c6400de2472407741849db1a1d7fbd78ca..912f807762e8f6ce22df3aacb2641d9aee3887c1 100644

--- a/lib/compiler/implementation/enqueue.dart

+++ b/lib/compiler/implementation/enqueue.dart

@@ -247,6 +247,10 @@ class Enqueuer {

String message = "$name != ${selector.name} (${selector.kind})";

compiler.internalError("Wrong selector name: $message.");

}

+ if (name == const SourceString('runtimeType')

+ && selector.argumentCount == 0) {

+ compiler.enabledRuntimeType = true;

ngeoffray 2012/09/14 07:30:21 I'd prefer doing the check on the Element. There a

karlklose 2012/09/14 12:07:13 Done.

+ }

Set<Selector> selectors =

selectorsMap.putIfAbsent(name, () => new Set<Selector>());

if (!selectors.contains(selector)) {