Add runtimeType() to Object which returns canonicalized instances of Type.

lib/compiler/implementation/ssa/ssa.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #library('ssa');
 
 #import('../closure.dart');
 #import('../js/js.dart', prefix: 'js');
 #import('../leg.dart');
 #import('../source_file.dart');
@@ skipping 21 matching lines @@
 #source('value_set.dart');
 
 class RuntimeTypeInformation {
   bool hasTypeArguments(DartType type) {
     if (type is InterfaceType) {
       InterfaceType interfaceType = type;
       return !interfaceType.arguments.isEmpty();
     }
     return false;
   }
+
+  static String forEachTypeVariable(Link collection,

[ngeoffray, 2012/09/17 15:31:14]

Add a top-level comment on what this method does.

[ngeoffray, 2012/09/17 15:31:14]

Link collection -> Link<TypeVariableType> collection

[kasperl, 2012/09/18 06:06:12]

Maybe change the name of this to stringifyTypeVariables?

[karlklose, 2012/09/19 06:40:45]

Done.

+                                    int numberOfInputs,
+                                    stringify(TypeVariableType variable,
+                                              bool hasValue)) {
+    int currentVariable = 0;
+    bool isFirst = true;
+    StringBuffer buffer = new StringBuffer();
+    collection.forEach((TypeVariableType variable) {
+      if (!isFirst) buffer.add(", ");
+      bool hasValue = currentVariable < numberOfInputs;
+      buffer.add(stringify(variable, hasValue));
+      isFirst = false;
+      currentVariable++;
+    });
+    return buffer.toString();
+  }
+
+  /**
+   * Generate a string representation template for this element, using '#' to
+   * denote the place for the type argument input. If there are more type
+   * variables than [numberOfInputs], 'Dynamic' is used as the value for these
+   * arguments.
+   */
+  static String generateRuntimeTypeString(ClassElement element,
+                                          int numberOfInputs) {
+    String elementName = element.name.slowToString();
+    if (element.typeVariables.isEmpty()) return "'$elementName'";
+    String stringify(_, hasValue) {

[ngeoffray, 2012/09/17 15:31:14]

Please add types to the parameters.

[karlklose, 2012/09/19 06:40:45]

Done.

[karlklose, 2012/09/19 06:40:45]

I added it for the hasValue. I use '_' as a marker that I am not interested in
the argument and I do not think that adding a type would increase readability
here.

+        return hasValue ? "' + # + '" : "Dynamic";

[ngeoffray, 2012/09/17 15:31:14]

Use the => notation?

[ngeoffray, 2012/09/17 15:31:14]

Why no ' + "Dynamic" + ' for the second case?

[karlklose, 2012/09/19 06:40:45]

Done.

[karlklose, 2012/09/19 06:40:45]

Done.

[karlklose, 2012/09/19 06:40:45]

Which case do you mean?

+    }
+    String arguments = forEachTypeVariable(element.typeVariables,
+                                           numberOfInputs,
+                                           stringify);
+    return "'$elementName<$arguments>'";
+  }
+
+  /**
+   * Generate a string template for the runtime type fields that contain the
+   * type descriptions of the reified type arguments, using '#' to denote the
+   * place for the type argument value, or [:null:] if there are more than
+   * [numberOfInputs] type variables.
+   */
+  static String generateTypeVariableString(ClassElement element,
+                                           int numberOfInputs) {
+    StringBuffer buffer = new StringBuffer();

[ngeoffray, 2012/09/17 15:31:14]

This is unused.

[karlklose, 2012/09/19 06:40:45]

Done, removed.

+    String result = forEachTypeVariable(element.typeVariables, numberOfInputs,
+                                        (variable, bool hasValue) {

[ngeoffray, 2012/09/17 15:31:14]

I find it easier to have this closure as a function statement (like in line 71)

[karlklose, 2012/09/19 06:40:45]

Done.

+      String value = hasValue ? "#" : "null";
+      return "'${variable.name.slowToString()}': $value";
+    });
+    return result;
+  }
 }