src/trusted/validator_x86/testdata/64/shl_alias.tf - Issue 10908137: (abandoned) Validator tests: convert hexes to TFs and run on bots (for prod. validator only)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/trusted/validator_x86/testdata/64/shl_alias.tf

Issue 10908137: (abandoned) Validator tests: convert hexes to TFs and run on bots (for prod. validator only) (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client

Patch Set: restore 'read overflow' and 'SegmentationError' Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« src/trusted/validator/x86/testing/tf/tf.py ('K') | « src/trusted/validator_x86/testdata/64/segment_store.tf ('k') | src/trusted/validator_x86/testdata/64/size_error.tf » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: src/trusted/validator_x86/testdata/64/shl_alias.tf

diff --git a/src/trusted/validator_x86/testdata/64/shl_alias.tf b/src/trusted/validator_x86/testdata/64/shl_alias.tf

new file mode 100644

index 0000000000000000000000000000000000000000..de83e97e53e3aad5b3773ffac087af57b9050c43

--- /dev/null

+++ b/src/trusted/validator_x86/testdata/64/shl_alias.tf

@@ -0,0 +1,29 @@

+BITS: 64

+OUTCOME: invalid

+# For background, see:

+# http://code.google.com/p/nativeclient/issues/detail?id=2576

+# "/4" encoding of SHL. This is what assemblers generate.

+asm: shl %cl,%edi

+hex: d3 e7

+asm: shl %edi

+hex: d1 e7

+asm: shl $0x2,%edi

+hex: c1 e7 02

+# "/6" encoding of SHL. This is an alias encoding, which we should

+# disallow on the grounds of minimalism.

+hex: d3 f7

+nc_out: ERROR: This instruction has been marked illegal by Native Client

+hex: d1 f7

+nc_out: ERROR: This instruction has been marked illegal by Native Client

+hex: c1 f7 02

+nc_out: ERROR: This instruction has been marked illegal by Native Client