Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Side by Side Diff: runtime/vm/disassembler_x64.cc

Issue 10908133: Eliminate a potential warning about extra format arguments. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/disassembler.h" 5 #include "vm/disassembler.h"
6 6
7 #include "vm/globals.h" // Needed here to get TARGET_ARCH_IA32. 7 #include "vm/globals.h" // Needed here to get TARGET_ARCH_IA32.
8 #if defined(TARGET_ARCH_X64) 8 #if defined(TARGET_ARCH_X64)
9 #include "platform/utils.h" 9 #include "platform/utils.h"
10 #include "vm/allocation.h" 10 #include "vm/allocation.h"
(...skipping 1540 matching lines...) Expand 10 before | Expand all | Expand 10 after
1551 break; 1551 break;
1552 case 4: 1552 case 4:
1553 mnem = "jmp"; 1553 mnem = "jmp";
1554 break; 1554 break;
1555 case 6: 1555 case 6:
1556 mnem = "push"; 1556 mnem = "push";
1557 break; 1557 break;
1558 default: 1558 default:
1559 mnem = "???"; 1559 mnem = "???";
1560 } 1560 }
1561 AppendToBuffer(((regop <= 1) ? "%s%c " : "%s "), 1561 if (regop <= 1) {
1562 mnem, 1562 AppendToBuffer("%s%c ", mnem, operand_size_code());
1563 operand_size_code()); 1563 } else {
1564 AppendToBuffer("%s ", mnem);
1565 }
1564 data += PrintRightOperand(data); 1566 data += PrintRightOperand(data);
1565 } 1567 }
1566 break; 1568 break;
1567 1569
1568 case 0xC7: // imm32, fall through 1570 case 0xC7: // imm32, fall through
1569 case 0xC6: // imm8 1571 case 0xC6: // imm8
1570 { 1572 {
1571 bool is_byte = *data == 0xC6; 1573 bool is_byte = *data == 0xC6;
1572 data++; 1574 data++;
1573 if (is_byte) { 1575 if (is_byte) {
(...skipping 282 matching lines...) Expand 10 before | Expand all | Expand 10 after
1856 human_buffer, 1858 human_buffer,
1857 sizeof(human_buffer), 1859 sizeof(human_buffer),
1858 pc); 1860 pc);
1859 pc += instruction_length; 1861 pc += instruction_length;
1860 } 1862 }
1861 } 1863 }
1862 1864
1863 } // namespace dart 1865 } // namespace dart
1864 1866
1865 #endif // defined TARGET_ARCH_X64 1867 #endif // defined TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698