Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1174)

Issue 10908130: Revert 155122 - Code to collect issue 97285 debugging info for crash reports. (Closed)

Created:
8 years, 3 months ago by Scott Hess - ex-Googler
Modified:
8 years, 3 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Revert 155122 - Code to collect issue 97285 debugging info for crash reports. [TPM is suspicious of Windows renderer crash rate. Seems impossible, but who knows?] It is useful to record breakpad keys for debugging, which is not applicable to multi-process bugs. This adds infrastructure to allow collection of information across processes. Also, fix so that GetPluginChannelHost() can successfully fail without crashing. BUG=97285, 141055 Review URL: https://chromiumcodereview.appspot.com/10908078 TBR=shess@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=155240

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -423 lines) Patch
M chrome/app/chrome_main_delegate.cc View 3 chunks +0 lines, -45 lines 0 comments Download
M content/browser/plugin_process_host.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/plugin_process_host.cc View 3 chunks +0 lines, -16 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 4 chunks +0 lines, -20 lines 0 comments Download
D content/common/content_debug_logging.cc View 1 chunk +0 lines, -45 lines 0 comments Download
D content/common/content_debug_logging_unittest.cc View 1 chunk +0 lines, -114 lines 0 comments Download
M content/common/plugin_messages.h View 1 chunk +0 lines, -8 lines 0 comments Download
M content/common/view_messages.h View 1 chunk +0 lines, -9 lines 0 comments Download
MM content/content_common.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +2 lines, -3 lines 0 comments Download
M content/plugin/plugin_thread.cc View 4 chunks +0 lines, -21 lines 0 comments Download
D content/public/common/content_debug_logging.h View 1 chunk +0 lines, -62 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 3 chunks +0 lines, -15 lines 0 comments Download
M content/renderer/webplugin_delegate_proxy.cc View 4 chunks +0 lines, -53 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Scott Hess - ex-Googler
8 years, 3 months ago (2012-09-06 20:58:51 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698