Issue 10908122: Add support for running low level profiler on Android.

Issue 10908122: Add support for running low level profiler on Android. (Closed)

Created:
8 years, 3 months ago by ulan

Modified:
8 years, 3 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Add support for running low level profiler on Android. R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=12469

Patch Set 2 : Address comments. #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -52 lines)			Patch
M	src/flag-definitions.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	src/platform-linux.cc	View		2 chunks	+1 line, -4 lines	0 comments	Download
M	src/platform-openbsd.cc	View		2 chunks	+1 line, -4 lines	0 comments	Download
A +	tools/android-ll-prof.sh	View	1	1 chunk	+41 lines, -35 lines	0 comments	Download
M	tools/ll_prof.py	View		5 chunks	+19 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ulan

Please take a look. https://chromiumcodereview.appspot.com/10908122/diff/1/src/platform-linux.cc File src/platform-linux.cc (left): https://chromiumcodereview.appspot.com/10908122/diff/1/src/platform-linux.cc#oldcode515 src/platform-linux.cc:515: static const char kGCFakeMmap[] = ...

8 years, 3 months ago (2012-09-06 14:11:20 UTC) #1

Michael Starzinger

LGTM (with a few comments). https://chromiumcodereview.appspot.com/10908122/diff/1/tools/android-ll-prof.sh File tools/android-ll-prof.sh (right): https://chromiumcodereview.appspot.com/10908122/diff/1/tools/android-ll-prof.sh#newcode2 tools/android-ll-prof.sh:2: Copyright header is missing. ...

8 years, 3 months ago (2012-09-06 14:23:16 UTC) #2

ulan

8 years, 3 months ago (2012-09-06 14:31:27 UTC) #3

Thanks, landing.

https://chromiumcodereview.appspot.com/10908122/diff/1/tools/android-ll-prof.sh
File tools/android-ll-prof.sh (right):

https://chromiumcodereview.appspot.com/10908122/diff/1/tools/android-ll-prof....
tools/android-ll-prof.sh:2: 
On 2012/09/06 14:23:16, Michael Starzinger wrote:
> Copyright header is missing.

Done.

https://chromiumcodereview.appspot.com/10908122/diff/1/tools/android-ll-prof....
tools/android-ll-prof.sh:20: BASE=`pwd`
On 2012/09/06 14:23:16, Michael Starzinger wrote:
> You could use the following to compute the base path and not rely on the
current
> directory being the v8 checkout.
> 
> tools_path=`cd $(dirname "$0");pwd`

Done.

https://chromiumcodereview.appspot.com/10908122/diff/1/tools/android-ll-prof....
tools/android-ll-prof.sh:21: DEPLOY=$BASE/deploy
On 2012/09/06 14:23:16, Michael Starzinger wrote:
> Put quotes around the value of DEPLOY.

Done.

https://chromiumcodereview.appspot.com/10908122/diff/1/tools/android-ll-prof....
tools/android-ll-prof.sh:39:
TOOLCHAIN=${ANDROID_NDK_ROOT}/toolchains/$ARCH/prebuilt/linux-x86/bin
On 2012/09/06 14:23:16, Michael Starzinger wrote:
> Put quotes around the value of TOOLCHAIN.

Done.

Expand Messages | Collapse Messages