Replace chrome::NOTIFICATION_EXTENSION_WARNING_CHANGED message with observer pattern

chrome/browser/extensions/extension_warning_set.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_warning_set.h"
 
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/extensions/extension_global_error_badge.h"
 #include "chrome/browser/extensions/extension_service.h"
@@ skipping 296 matching lines @@
       !g_browser_process->profile_manager()->IsValidProfile(profile)) {
     return;
   }
 
   extensions::ExtensionWarningService* warning_service =
       extensions::ExtensionSystem::Get(profile)->warning_service();
 
   warning_service->AddWarnings(warnings.Pass());
 }
 
+void ExtensionWarningService::AddObserver(
+    ExtensionWarningService::Observer* observer) {
+  observer_list_.AddObserver(observer);
+}
+
+void ExtensionWarningService::RemoveObserver(
+    ExtensionWarningService::Observer* observer) {
+  observer_list_.RemoveObserver(observer);
+}
+
 void ExtensionWarningService::SuppressBadgeForCurrentWarnings() {
   DCHECK(CalledOnValidThread());
   badge_suppressions_.insert(warnings_.begin(), warnings_.end());
   UpdateWarningBadge();
 }
 
 void ExtensionWarningService::NotifyWarningsChanged() {
   DCHECK(CalledOnValidThread());
-  content::NotificationService::current()->Notify(
-      chrome::NOTIFICATION_EXTENSION_WARNING_CHANGED,
-      content::Source<Profile>(profile_),
-      content::NotificationService::NoDetails());
+  FOR_EACH_OBSERVER(Observer, observer_list_, ExtensionWarningsChanged());
 }
 
 void ExtensionWarningService::UpdateWarningBadge() {
   DCHECK(CalledOnValidThread());
   // We need a badge if a warning exists that has not been suppressed.
   bool need_warning_badge = false;
   for (const_iterator i = warnings_.begin(); i != warnings_.end(); ++i) {
     if (badge_suppressions_.find(*i) == badge_suppressions_.end()) {
       need_warning_badge = true;
       break;
     }
   }
 
   GlobalErrorService* service =
       GlobalErrorServiceFactory::GetForProfile(profile_);
   GlobalError* error = service->GetGlobalErrorByMenuItemCommandID(
       ExtensionGlobalErrorBadge::GetMenuItemCommandID());
 
   // Activate or hide the warning badge in case the current state is incorrect.
   if (error && !need_warning_badge) {
     service->RemoveGlobalError(error);
     delete error;
   } else if (!error && need_warning_badge) {
     service->AddGlobalError(new ExtensionGlobalErrorBadge);
   }
 }
 
 }  // namespace extensions