Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1251)

Unified Diff: build/common.gypi

Issue 10908115: Always drop a tombstone (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/app/breakpad_linux.cc » ('j') | chrome/app/breakpad_linux.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index ae9c4611c3638d913fb7b7315c487ee114675a75..f6bcea24b4d87f0abe43f367b203f1a3b616492f 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -2528,6 +2528,11 @@
['OS=="android"', {
'variables': {
'target_arch%': 'arm', # target_arch in android terms.
+ # The location where debug symbols are archived. This is written to the
+ # device log on crashes just prior to dropping a tombstone so that
+ # tools can locate the symbols from the crash log. This is added to the
+ # Gyp defines by the buildbots that actually archive symbols.
Lei Zhang 2012/09/06 19:13:36 s/Gyp defines/GYP_DEFINES/ ?
cjhopman 2012/09/07 18:09:20 Done.
+ 'chrome_symbols_location%': '',
'conditions': [
# Android uses x86 instead of ia32 for their target_arch designation.
['target_arch=="ia32"', {
@@ -2612,6 +2617,7 @@
'__GNU_SOURCE=1', # Necessary for clone()
'USE_STLPORT=1',
'_STLP_USE_PTR_SPECIALIZATIONS=1',
+ 'CHROME_SYMBOLS_LOCATION="<(chrome_symbols_location)"',
],
'ldflags!': [
'-pthread', # Not supported by Android toolchain.
« no previous file with comments | « no previous file | chrome/app/breakpad_linux.cc » ('j') | chrome/app/breakpad_linux.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698