Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Unified Diff: build/common.gypi

Issue 10908115: Always drop a tombstone (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Rebase Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/app/breakpad_linux.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 8df35e00ed9201797981ba3e3e0d2c28e76cd5a9..d0eef17fd756220113894ce8344732a807962a55 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -2527,6 +2527,12 @@
['OS=="android"', {
'variables': {
'target_arch%': 'arm', # target_arch in android terms.
+ # This is the id for the archived chrome symbols. Each build that
+ # archives symbols is assigned an id which is then added to GYP_DEFINES.
+ # This is written to the device log on crashes just prior to dropping a
+ # tombstone. Tools can determine the location of the archived symbols
+ # from the id.
+ 'chrome_symbols_id%': '',
'conditions': [
# Android uses x86 instead of ia32 for their target_arch designation.
['target_arch=="ia32"', {
@@ -2611,6 +2617,7 @@
'__GNU_SOURCE=1', # Necessary for clone()
'USE_STLPORT=1',
'_STLP_USE_PTR_SPECIALIZATIONS=1',
+ 'CHROME_SYMBOLS_ID="<(chrome_symbols_id)"',
],
'ldflags!': [
'-pthread', # Not supported by Android toolchain.
« no previous file with comments | « no previous file | chrome/app/breakpad_linux.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698