Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 10908114: Move SelectFaviconFrames from favicon/ to history/ (Closed)

Created:
8 years, 3 months ago by pkotwicz
Modified:
8 years, 3 months ago
Reviewers:
Nico, sky
CC:
chromium-reviews, browser-components-watch_chromium.org
Visibility:
Public.

Description

Move SelectFaviconFrames from favicon/ to history/ so that HistoryBackend can use it. BUG=10802066 Test=chrome and unit_tests compile R=thakis TBR=sky Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155139

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -522 lines) Patch
M chrome/browser/favicon/favicon_service.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/favicon/favicon_tab_helper.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/favicon/favicon_util.cc View 1 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/favicon/select_favicon_frames.h View 1 chunk +0 lines, -33 lines 0 comments Download
D chrome/browser/favicon/select_favicon_frames.cc View 1 chunk +0 lines, -248 lines 0 comments Download
D chrome/browser/favicon/select_favicon_frames_unittest.cc View 1 chunk +0 lines, -230 lines 0 comments Download
A + chrome/browser/history/select_favicon_frames.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/history/select_favicon_frames.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/history/select_favicon_frames_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
pkotwicz
8 years, 3 months ago (2012-09-06 00:23:03 UTC) #1
Nico
lgtm
8 years, 3 months ago (2012-09-06 00:25:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10908114/1
8 years, 3 months ago (2012-09-06 00:58:10 UTC) #3
commit-bot: I haz the power
Failed to apply patch for chrome/browser/favicon/favicon_service.cc: While running patch -p1 --forward --force; patching file chrome/browser/favicon/favicon_service.cc ...
8 years, 3 months ago (2012-09-06 00:58:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10908114/6001
8 years, 3 months ago (2012-09-06 03:01:25 UTC) #5
commit-bot: I haz the power
8 years, 3 months ago (2012-09-06 07:27:16 UTC) #6
Change committed as 155139

Powered by Google App Engine
This is Rietveld 408576698