Issue 10908113: Add isolate.py trace --merge to do a trace and merge in a single command.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10908113: Add isolate.py trace --merge to do a trace and merge in a single command. (Closed)

Created:
8 years, 3 months ago by M-A Ruel

Modified:
8 years, 3 months ago

Reviewers:
csharp

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add isolate.py trace --merge to do a trace and merge in a single command. TBR=csharp@chromium.org NOTRY=true BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155228

Patch Set 1 #

Total comments: 2

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -21 lines)			Patch
	M	tools/isolate/isolate.py	View		4 chunks	+32 lines, -21 lines	2 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

csharp

LGTM with nit https://chromiumcodereview.appspot.com/10908113/diff/1/tools/isolate/isolate.py File tools/isolate/isolate.py (right): https://chromiumcodereview.appspot.com/10908113/diff/1/tools/isolate/isolate.py#newcode670 tools/isolate/isolate.py:670: value = read(complete_state) Nit: what exactly ...

8 years, 3 months ago (2012-09-06 12:59:37 UTC) #2

M-A Ruel

https://chromiumcodereview.appspot.com/10908113/diff/1/tools/isolate/isolate.py File tools/isolate/isolate.py (right): https://chromiumcodereview.appspot.com/10908113/diff/1/tools/isolate/isolate.py#newcode670 tools/isolate/isolate.py:670: value = read(complete_state) On 2012/09/06 12:59:37, csharp wrote: > ...

8 years, 3 months ago (2012-09-06 19:26:50 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/10908113/1

8 years, 3 months ago (2012-09-06 19:27:18 UTC) #4

Change committed as 155228

Expand Messages | Collapse Messages