Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Unified Diff: editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/index/AnalysisMarkerManager.java

Issue 10908103: Use of undefined class in const constructor should be an error (issue 4882) (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/index/AnalysisMarkerManager.java
===================================================================
--- editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/index/AnalysisMarkerManager.java (revision 11901)
+++ editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/index/AnalysisMarkerManager.java (working copy)
@@ -16,7 +16,6 @@
import com.google.dart.compiler.DartCompilationError;
import com.google.dart.compiler.ErrorCode;
import com.google.dart.compiler.ErrorSeverity;
-import com.google.dart.compiler.SubSystem;
import com.google.dart.tools.core.DartCore;
import com.google.dart.tools.core.analysis.AnalysisError;
import com.google.dart.tools.core.analysis.AnalysisEvent;
@@ -66,9 +65,7 @@
int severity;
ErrorSeverity errorSeverity = error.getErrorCode().getErrorSeverity();
- if (error.getErrorCode().getSubSystem() == SubSystem.STATIC_TYPE) {
- severity = IMarker.SEVERITY_WARNING;
- } else if (errorSeverity == ErrorSeverity.ERROR) {
+ if (errorSeverity == ErrorSeverity.ERROR) {
severity = IMarker.SEVERITY_ERROR;
} else if (errorSeverity == ErrorSeverity.WARNING || errorSeverity == ErrorSeverity.INFO) {
severity = IMarker.SEVERITY_WARNING;
@@ -98,8 +95,9 @@
marker.setAttribute(IMarker.LINE_NUMBER, lineNumber);
marker.setAttribute("errorCode", errorCodeString);
} catch (CoreException e) {
- DartCore.logError("Failed to create marker for " + res + "\n at " + offset + " message: "
- + errMsg, e);
+ DartCore.logError(
+ "Failed to create marker for " + res + "\n at " + offset + " message: " + errMsg,
+ e);
}
}
« no previous file with comments | « compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698