Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Unified Diff: compiler/java/com/google/dart/compiler/resolver/Resolver.java

Issue 10908103: Use of undefined class in const constructor should be an error (issue 4882) (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: compiler/java/com/google/dart/compiler/resolver/Resolver.java
===================================================================
--- compiler/java/com/google/dart/compiler/resolver/Resolver.java (revision 11901)
+++ compiler/java/com/google/dart/compiler/resolver/Resolver.java (working copy)
@@ -1495,16 +1495,17 @@
}
@Override
- public Element visitNewExpression(DartNewExpression x) {
+ public Element visitNewExpression(final DartNewExpression x) {
this.visit(x.getArguments());
Element element = x.getConstructor().accept(getContext().new Selector() {
// Only 'new' expressions can have a type in a property access.
@Override
public Element visitTypeNode(DartTypeNode type) {
+ TypeErrorCode errorCode = x.isConst() ? TypeErrorCode.NO_SUCH_TYPE_CONST : TypeErrorCode.NO_SUCH_TYPE;
return recordType(type, resolveType(type, inStaticContext(currentMethod),
inFactoryContext(currentMethod),
- TypeErrorCode.NO_SUCH_TYPE,
+ errorCode,
ResolverErrorCode.WRONG_NUMBER_OF_TYPE_ARGUMENTS));
}
« no previous file with comments | « no previous file | compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698