Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1312)

Unified Diff: content/browser/browser_plugin/browser_plugin_embedder.cc

Issue 10908099: Copy renderer preferences from embedder to guest. (Closed) Base URL: http://git.chromium.org/chromium/src.git@tmp
Patch Set: Sync to HEAD, diff conflict otherwise. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/browser_plugin/browser_plugin_embedder.cc
diff --git a/content/browser/browser_plugin/browser_plugin_embedder.cc b/content/browser/browser_plugin/browser_plugin_embedder.cc
index d8a78566c59ead9cebd710705b6afe88d6e355bc..00b85a803c443066fb98a0763645f5b59423f85d 100644
--- a/content/browser/browser_plugin/browser_plugin_embedder.cc
+++ b/content/browser/browser_plugin/browser_plugin_embedder.cc
@@ -95,8 +95,17 @@ void BrowserPluginEmbedder::NavigateGuest(RenderViewHost* render_view_host,
guest->set_embedder_render_process_host(
render_view_host->GetProcess());
- guest_web_contents->GetMutableRendererPrefs()->
- throttle_input_events = false;
+ RendererPreferences* guest_renderer_prefs =
+ guest_web_contents->GetMutableRendererPrefs();
+ // Copy renderer preferences (and nothing else) from the embedder's
+ // TabContents to the guest.
+ //
+ // For GTK and Aura this is necessary to get proper renderer configuration
+ // values for caret blinking interval, colors related to selection and
+ // focus.
+ *guest_renderer_prefs = *web_contents()->GetMutableRendererPrefs();
+
+ guest_renderer_prefs->throttle_input_events = false;
AddGuest(instance_id, guest_web_contents);
guest_web_contents->SetDelegate(guest);
} else {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698