Cleanup: Constify some ProfileKeyedBaseFactory methods and all overrides. Remove ProfileKeyedBaseFa…

chrome/browser/profiles/profile_keyed_base_factory.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_keyed_base_factory.h"
 
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profile_dependency_manager.h"
 
 ProfileKeyedBaseFactory::ProfileKeyedBaseFactory(
@@ skipping 63 matching lines @@
   // parallel) and we don't want to register multiple times on the same profile.
   DCHECK(!profile->IsOffTheRecord());
 
   std::set<Profile*>::iterator it = registered_preferences_.find(profile);
   if (it == registered_preferences_.end()) {
     RegisterUserPrefs(profile->GetPrefs());
     registered_preferences_.insert(profile);
   }
 }
 
-void ProfileKeyedBaseFactory::ForceRegisterPrefsForTest(PrefService* prefs) {
-  RegisterUserPrefs(prefs);
-}
-
-bool ProfileKeyedBaseFactory::ServiceRedirectedInIncognito() {
+bool ProfileKeyedBaseFactory::ServiceRedirectedInIncognito() const {
   return false;
 }
 
-bool ProfileKeyedBaseFactory::ServiceHasOwnInstanceInIncognito() {
+bool ProfileKeyedBaseFactory::ServiceHasOwnInstanceInIncognito() const {
   return false;
 }
 
-bool ProfileKeyedBaseFactory::ServiceIsCreatedWithProfile() {
+bool ProfileKeyedBaseFactory::ServiceIsCreatedWithProfile() const {
   return false;
 }
 
-bool ProfileKeyedBaseFactory::ServiceIsNULLWhileTesting() {
+bool ProfileKeyedBaseFactory::ServiceIsNULLWhileTesting() const {
   return false;
 }
 
 void ProfileKeyedBaseFactory::ProfileDestroyed(Profile* profile) {
   // While object destruction can be customized in ways where the object is
   // only dereferenced, this still must run on the UI thread.
   DCHECK(CalledOnValidThread());
 
   registered_preferences_.erase(profile);
 }
 
-bool ProfileKeyedBaseFactory::ArePreferencesSetOn(Profile* profile) {
+bool ProfileKeyedBaseFactory::ArePreferencesSetOn(Profile* profile) const {
   return registered_preferences_.find(profile) !=
       registered_preferences_.end();
 }
 
 void ProfileKeyedBaseFactory::MarkPreferencesSetOn(Profile* profile) {
   DCHECK(!ArePreferencesSetOn(profile));
   registered_preferences_.insert(profile);
 }