Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(25)

Issue 10908086: Merge 127520 - REGRESSION(r120832): RenderLayer::clampScrollOffset doesn't properly clamp (Closed)

Created:
8 years, 6 months ago by Julien - ping for review
Modified:
8 years, 6 months ago
Reviewers:
jchaffraix
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1229/
Visibility:
Public.

Description

Merge 127520 - REGRESSION(r120832): RenderLayer::clampScrollOffset doesn't properly clamp https://bugs.webkit.org/show_bug.cgi?id=95776 Reviewed by Simon Fraser. .: * ManualTests/select-menu-list-wrongly-positioned.html: Added. Source/WebCore: r120832 consolidated the clamping logic into RenderLayer::clampScrollOffset. The existing code wouldn't properly ensure that the offset were positive which got exposed to other code paths, leading to the regression. Tested by ManualTests/select-menu-list-wrongly-positioned.html as I didn't find a way to create a reliable layout test. * rendering/RenderLayer.cpp: (WebCore::RenderLayer::clampScrollOffset): Fixed the clamping logic to ensure that the scroll offset's dimensions are positive. TBR=jchaffraix@webkit.org Committed: https://trac.webkit.org/changeset/127545

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
A + ManualTests/select-menu-list-wrongly-positioned.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/rendering/RenderLayer.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Julien - ping for review
8 years, 6 months ago (2012-09-05 02:46:44 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698