Code to collect issue 97285 debugging info for crash reports.

content/browser/plugin_process_host.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/plugin_process_host.h"
 
 #if defined(OS_WIN) && !defined(USE_AURA)
 #include <windows.h>
 #elif defined(OS_POSIX)
 #include <utility>  // for pair<>
@@ skipping 14 matching lines @@
 #include "content/browser/browser_child_process_host_impl.h"
 #include "content/browser/gpu/gpu_data_manager_impl.h"
 #include "content/browser/plugin_service_impl.h"
 #include "content/common/child_process_host_impl.h"
 #include "content/common/plugin_messages.h"
 #include "content/common/resource_messages.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/content_browser_client.h"
 #include "content/public/browser/notification_types.h"
 #include "content/public/browser/plugin_service.h"
+#include "content/public/common/content_debug_logging.h"
 #include "content/public/common/content_switches.h"
 #include "content/public/common/process_type.h"
 #include "ipc/ipc_switches.h"
 #include "ui/base/ui_base_switches.h"
 #include "ui/gfx/native_widget_types.h"
 #include "ui/gl/gl_switches.h"
 
 using content::BrowserThread;
 using content::ChildProcessData;
 using content::ChildProcessHost;
@@ skipping 281 matching lines @@
 #if defined(OS_MACOSX)
     IPC_MESSAGE_HANDLER(PluginProcessHostMsg_PluginSelectWindow,
                         OnPluginSelectWindow)
     IPC_MESSAGE_HANDLER(PluginProcessHostMsg_PluginShowWindow,
                         OnPluginShowWindow)
     IPC_MESSAGE_HANDLER(PluginProcessHostMsg_PluginHideWindow,
                         OnPluginHideWindow)
     IPC_MESSAGE_HANDLER(PluginProcessHostMsg_PluginSetCursorVisibility,
                         OnPluginSetCursorVisibility)
 #endif
+    IPC_MESSAGE_HANDLER(PluginProcessHostMsg_RecordMsg, OnRecordMsg)
+    IPC_MESSAGE_HANDLER(PluginProcessHostMsg_GetMessages, OnGetMessages)
     IPC_MESSAGE_UNHANDLED(handled = false)
   IPC_END_MESSAGE_MAP()
 
   DCHECK(handled);
   return handled;
 }
 
 void PluginProcessHost::OnChannelConnected(int32 peer_pid) {
   for (size_t i = 0; i < pending_requests_.size(); ++i) {
     RequestPluginChannel(pending_requests_[i]);
@@ skipping 101 matching lines @@
 }
 
 void PluginProcessHost::OnChannelCreated(
     const IPC::ChannelHandle& channel_handle) {
   Client* client = sent_requests_.front();
 
   if (client)
     client->OnChannelOpened(channel_handle);
   sent_requests_.pop_front();
 }
+
+// TODO(shess): Could this be annotated WRT the sending plugin?
+void PluginProcessHost::OnRecordMsg(int bug_id, const std::string& msg) {
+  content::debug::RecordMsg(bug_id, msg);
+}
+
+void PluginProcessHost::OnGetMessages(int bug_id,
+                                      std::vector<std::string>* msgs) {
+  if (!content::debug::GetMessages(bug_id, msgs))

[Bernhard Bauer, 2012/09/05 15:04:55]

Doesn't GetMessages() return false if the out vector is empty? Why do we need to
clear it then?

[Scott Hess - ex-Googler, 2012/09/05 17:17:05]

GetMessages() returns false if there is no handler, or if the handler returns
false.  Maybe the way to go is to document the API as false implying *msgs is
empty.

The GetMessages() return value was meant to allow distinguishing between "nobody
provided results" and "results were provided, they were just empty".  The IPC
version encodes that distinction in empty results because I'm lazy.  But now
that it seems to work, maybe I should just go back and layer in an explicit bool
for that, rather than making stuff up.

+    msgs->clear();
+}