Issue 10908074: mac: Use convertSizeFromBacking: instead of the deprecated ...FromBase:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10908074: mac: Use convertSizeFromBacking: instead of the deprecated ...FromBase: (Closed)

Created:
8 years, 3 months ago by Nico

Modified:
8 years, 3 months ago

Reviewers:
Avi (use Gerrit), sail

CC:
chromium-reviews, Avi (use Gerrit)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

mac: Use convertSizeFromBacking: instead of the deprecated ...FromBase: Using convertSizeFromBase: makes 10.8 log a warning message, and all retina macs run at least 10.7 (where convertSizeFromBacking: became available) anyway. Also protect Lion API declarations with MAC_OS_X_VERSION_MAX_ALLOWED checks in a few places. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=154808

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Total comments: 1

Patch Set 4 : . #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -5 lines)			Patch
M	chrome/browser/ui/cocoa/nsview_additions.mm	View	1 2 3	1 chunk	+13 lines, -3 lines	0 comments	Download
M	ui/base/layout_mac.mm	View	1	2 chunks	+5 lines, -0 lines	0 comments	Download
M	ui/gfx/screen_mac.mm	View	1	1 chunk	+7 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Avi (use Gerrit)

lgtm https://chromiumcodereview.appspot.com/10908074/diff/9001/chrome/browser/ui/cocoa/nsview_additions.mm File chrome/browser/ui/cocoa/nsview_additions.mm (right): https://chromiumcodereview.appspot.com/10908074/diff/9001/chrome/browser/ui/cocoa/nsview_additions.mm#newcode19 chrome/browser/ui/cocoa/nsview_additions.mm:19: // All shipping retina macs run at least ...

8 years, 3 months ago (2012-09-04 20:17:23 UTC) #3

commit-bot: I haz the power

8 years, 3 months ago (2012-09-04 20:27:21 UTC) #5

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/10908074/2003

Expand Messages | Collapse Messages