Better tracking of provided types at call sites

lib/compiler/implementation/universe.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class Universe {
   Map<Element, CodeBuffer> generatedCode;
   Map<Element, CodeBuffer> generatedBailoutCode;
   final Set<ClassElement> instantiatedClasses;
   final Set<SourceString> instantiatedClassInstanceFields;
   final Set<FunctionElement> staticFunctionsNeedingGetter;
@@ skipping 304 matching lines @@
     if (namedArguments.isEmpty()) return namedArguments;
     if (!orderedNamedArguments.isEmpty()) return orderedNamedArguments;
 
     orderedNamedArguments.addAll(namedArguments);
     orderedNamedArguments.sort((SourceString first, SourceString second) {
       return first.slowToString().compareTo(second.slowToString());
     });
     return orderedNamedArguments;
   }
 
-  toString() => 'Selector($kind, $name, $argumentCount)';
+  String namedArgumentsToString() {
+    StringBuffer result = new StringBuffer();

[kasperl, 2012/09/05 07:06:29]

Don't do the allocation of this if namedArgumentCount == 0?

[Søren Gjesse, 2012/09/05 08:02:59]

Done.

+    if (namedArgumentCount > 0) {
+      result.add('[');

[kasperl, 2012/09/05 07:06:29]

How about not adding [ and ] and just returning "[$result]"?

[Søren Gjesse, 2012/09/05 08:02:59]

Done.

+      for (int i = 0; i < namedArgumentCount; i++) {
+        if (i != 0) result.add(', ');
+        result.add(namedArguments[i].slowToString());
+      }
+      result.add(']');
+      return result.toString();
+    }
+    return '';
+  }
+
+  String toString() {
+    String named = '';
+    if (namedArgumentCount > 0) named = ', named=${namedArgumentsToString()}';
+    return 'Selector($kind, ${name.slowToString()}, '
+           'arity=$argumentCount$named)';
+  }
 }
 
 class TypedSelector extends Selector {
   /**
    * The type of the receiver. Any subtype of that type can be the
    * target of the invocation.
    */
   final DartType receiverType;
 
   TypedSelector(this.receiverType, Selector selector)
@@ skipping 45 matching lines @@
 
     if (!self.isInterface() && self.isSubclassOf(other)) {
       // Resolve an invocation of [element.name] on [self]. If it
       // is found, this selector is a candidate.
       return hasElementIn(self, element) && appliesUntyped(element, compiler);
     }
 
     return false;
   }
 
-  toString() {
-    return 'Selector($kind, "${name.slowToString()}", '
-           '$argumentCount, type=$receiverType)';
+  String toString() {

[kasperl, 2012/09/05 07:06:29]

How about getting rid of this and just use the one from the superclass -- and
add printing of the type up there if it isn't null?

[Søren Gjesse, 2012/09/05 08:02:59]

Good point, done.

+    String named = '';
+    if (namedArgumentCount > 0) named = ', named=${namedArgumentsToString()}';
+    return 'Selector($kind, ${name.slowToString()}, '
+           'arity=$argumentCount$named, type=$receiverType)';
   }
 }