Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 10908067: Add ZipReader::OpenFromString(). (Closed)

Created:
8 years, 3 months ago by Hironori Bono
Modified:
8 years, 2 months ago
Reviewers:
Nico, satorux1
CC:
chromium-reviews
Visibility:
Public.

Description

Add ZipReader::OpenFromString(). This change adds a function OpenFromString to the ZipReader class so we can extract files from a zip archive stored in memory without using temporary files. BUG=47083 TEST=ZipReaderTest.OpenFromString. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=160790

Patch Set 1 : #

Total comments: 26

Patch Set 2 : #

Patch Set 3 : #

Total comments: 8

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -0 lines) Patch
M chrome/common/zip_internal.h View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/common/zip_internal.cc View 1 2 3 3 chunks +124 lines, -0 lines 0 comments Download
M chrome/common/zip_reader.h View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/common/zip_reader.cc View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/common/zip_reader_unittest.cc View 1 2 3 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Hironori Bono
Greetings Satoru-san, To write the background of this change, I'm going to upload a zip ...
8 years, 3 months ago (2012-09-05 03:22:20 UTC) #1
satorux1
Sorry for the belated response, I was ooo until yesterday. The feature looks pretty useful. ...
8 years, 3 months ago (2012-09-06 17:49:09 UTC) #2
Hironori Bono
Greetings Satoru-san, Thank you for your review and comments. (I took a vacation and it ...
8 years, 2 months ago (2012-10-01 09:45:11 UTC) #3
Hironori Bono
ping?
8 years, 2 months ago (2012-10-03 09:22:16 UTC) #4
satorux1
sorry for the belated response. I was busy for random chores in the past few ...
8 years, 2 months ago (2012-10-03 12:48:38 UTC) #5
satorux1
LGTM http://codereview.chromium.org/10908067/diff/14007/chrome/common/zip_internal.cc File chrome/common/zip_internal.cc (right): http://codereview.chromium.org/10908067/diff/14007/chrome/common/zip_internal.cc#newcode217 chrome/common/zip_internal.cc:217: buffer->length = data.length(); On 2012/10/01 09:45:11, Hironori Bono ...
8 years, 2 months ago (2012-10-04 00:11:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hbono@chromium.org/10908067/20003
8 years, 2 months ago (2012-10-05 04:31:53 UTC) #7
commit-bot: I haz the power
Presubmit check for 10908067-20003 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 2 months ago (2012-10-05 04:31:56 UTC) #8
Hironori Bono
Greetings Nico, Is it possible to review this change? (It seems chrome/common does not have ...
8 years, 2 months ago (2012-10-05 04:44:53 UTC) #9
Nico
lgtm The only real comment I have is about reinterpret_cast, feel free to ignore the ...
8 years, 2 months ago (2012-10-05 05:03:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hbono@chromium.org/10908067/37001
8 years, 2 months ago (2012-10-09 01:59:27 UTC) #11
Hironori Bono
Greetings Nico, Thank you for your review. I have applied some of your comments and ...
8 years, 2 months ago (2012-10-09 02:00:05 UTC) #12
commit-bot: I haz the power
8 years, 2 months ago (2012-10-09 04:41:18 UTC) #13
Change committed as 160790

Powered by Google App Engine
This is Rietveld 408576698