Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2387)

Unified Diff: chrome/browser/extensions/extension_input_api.cc

Issue 10908053: extensions: Extract the dependency on browser_view from extension_input_api.cc. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix naming nit Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/top_level_widget.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_input_api.cc
diff --git a/chrome/browser/extensions/extension_input_api.cc b/chrome/browser/extensions/extension_input_api.cc
index 8672566d37725d55fc94231abf4399bcbd8b8f41..96e2eb8e0b9c294dd76e2c25235947525e32c5b4 100644
--- a/chrome/browser/extensions/extension_input_api.cc
+++ b/chrome/browser/extensions/extension_input_api.cc
@@ -10,13 +10,10 @@
#include "base/string_util.h"
#include "base/values.h"
#include "chrome/browser/extensions/key_identifier_conversion_views.h"
-#include "chrome/browser/ui/browser.h"
-#include "chrome/browser/ui/browser_window.h"
-#include "chrome/browser/ui/views/frame/browser_view.h"
+#include "chrome/browser/ui/top_level_widget.h"
#include "chrome/common/chrome_notification_types.h"
#include "ui/base/event.h"
#include "ui/views/ime/input_method.h"
-#include "ui/views/views_delegate.h"
#include "ui/views/widget/widget.h"
namespace {
@@ -63,18 +60,6 @@ uint16 UnicodeIdentifierStringToInt(const std::string& key_identifier) {
return character;
}
-views::Widget* GetTopLevelWidget(Browser* browser) {
- if (!browser)
- return NULL;
-
- BrowserWindow* window = browser->window();
- if (!window)
- return NULL;
-
- BrowserView* browser_view = BrowserView::GetBrowserViewForBrowser(browser);
- return browser_view ? browser_view->GetWidget() : NULL;
-}
-
} // namespace
bool SendKeyboardEventInputFunction::RunImpl() {
@@ -117,7 +102,8 @@ bool SendKeyboardEventInputFunction::RunImpl() {
return false;
}
- views::Widget* widget = GetTopLevelWidget(GetCurrentBrowser());
+ views::Widget* widget =
+ chrome::GetTopLevelWidgetForBrowser(GetCurrentBrowser());
if (!widget) {
error_ = kNoValidRecipientError;
return false;
« no previous file with comments | « no previous file | chrome/browser/ui/top_level_widget.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698