Issue 10908053: extensions: Extract the dependency on browser_view from extension_input_api.cc.

Issue 10908053: extensions: Extract the dependency on browser_view from extension_input_api.cc. (Closed)

Created:
8 years, 3 months ago by tfarina

Modified:
8 years, 3 months ago

Reviewers:
Aaron Boodman, Ben Goodger (Google)

CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, yusukes+watch_chromium.org, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

extensions: Extract the dependency on browser_view from extension_input_api.cc. BUG=125846 R=aa@chromium.org,ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=154950

Patch Set 2 : fix naming nit #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -17 lines)			Patch
M	chrome/browser/extensions/extension_input_api.cc	View	1	3 chunks	+3 lines, -17 lines	0 comments	Download
A	chrome/browser/ui/top_level_widget.h	View	1	1 chunk	+20 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/views/top_level_widget_views.cc	View	1	1 chunk	+25 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

LGTM with the naming nit below http://codereview.chromium.org/10908053/diff/1/chrome/browser/ui/top_level_widget.h File chrome/browser/ui/top_level_widget.h (right): http://codereview.chromium.org/10908053/diff/1/chrome/browser/ui/top_level_widget.h#newcode16 chrome/browser/ui/top_level_widget.h:16: views::Widget* GetTopLevelWidget(Browser* browser); ...

8 years, 3 months ago (2012-09-04 15:30:01 UTC) #2

tfarina

http://codereview.chromium.org/10908053/diff/1/chrome/browser/ui/top_level_widget.h File chrome/browser/ui/top_level_widget.h (right): http://codereview.chromium.org/10908053/diff/1/chrome/browser/ui/top_level_widget.h#newcode16 chrome/browser/ui/top_level_widget.h:16: views::Widget* GetTopLevelWidget(Browser* browser); On 2012/09/04 15:30:01, Ben Goodger (Google) ...

8 years, 3 months ago (2012-09-04 15:34:58 UTC) #3

lgtm

Expand Messages | Collapse Messages